Date: Tue, 3 Feb 2026 17:27:24 +0100
From: Christoph Berg <myon@debian.org>
To: Sami Imseih <samimseih@gmail.com>
Cc: Pavlo Golub <pavlo.golub@cybertec.at>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Re[2]: [PATCH] Add last_executed timestamp to pg_stat_statements
Message-ID: <aYIh7I9khvoewwH_@msg.df7cb.de>
References: <CAK7ymc+FxoVswo1ok_xDW-xPG-ZEZ8SAqCUkJ7WF04=0aQDvVQ@mail.gmail.com>
 <CAA5RZ0uyvnNuHRj=73jZhocnLxE07oM-AeSLS=FUuuZ_hy7fKA@mail.gmail.com>
 <em5be966c3-9086-4f3f-b516-97444b854fdf@10e48d49.com>
 <CAA5RZ0u6qdcLoWJJz5mUB_VYZqT__U-HJJ5_ioYO7XGsUfXfpw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAA5RZ0u6qdcLoWJJz5mUB_VYZqT__U-HJJ5_ioYO7XGsUfXfpw@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aYIh7I9khvoewwH_%40msg.df7cb.de>
Precedence: bulk

Re: Sami Imseih
> I wonder if we can use GetCurrentStatementStartTimestamp()
> instead?

The main use case for this column is being able to retrieve the stats
that were updated since the last time one was looking. That only works
if it's the statement end time, or else long-running statements
spanning more than one poll interval would be missed.

Perhaps the column should rather be called "stats_last_updated" to
match "stats_since", and be moved to the very end? Similarly, nested
statements would also have to get that stamp.

Oh and, yes, I'm definitely +1 on this feature.

Christoph