Date: Fri, 6 Feb 2026 13:21:09 +0100
From: Christoph Berg <myon@debian.org>
To: Pavlo Golub <pavlo.golub@cybertec.at>
Cc: Sami Imseih <samimseih@gmail.com>,
	Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Add last_executed timestamp to pg_stat_statements
Message-ID: <aYXcteoB-JSqP4m9@msg.df7cb.de>
References: <em5be966c3-9086-4f3f-b516-97444b854fdf@10e48d49.com>
 <CAA5RZ0u6qdcLoWJJz5mUB_VYZqT__U-HJJ5_ioYO7XGsUfXfpw@mail.gmail.com>
 <aYIh7I9khvoewwH_@msg.df7cb.de>
 <CAA5RZ0tH_+3JGMCktkp8EMyvKaRAJf-xRh+y_UoZ8azvuUEAYQ@mail.gmail.com>
 <aYMKolTlvzenr4Pk@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAK7ymc+E00zKC9Da+BK2se=O2RiOUkdW5dz4iAynD1Vj=Pwexg@mail.gmail.com>
 <CAA5RZ0u_jjiLc_w4nksdVazvvqtE17C1nM=sKf9fy5x02orfsg@mail.gmail.com>
 <emed32d635-e46b-4f08-9085-3fd822fe5765@cybertec.at>
 <aYXH4hkFc_2xOa8t@msg.df7cb.de>
 <ema0100e49-522e-4b8f-9c25-9257af1f0793@cybertec.at>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ema0100e49-522e-4b8f-9c25-9257af1f0793@cybertec.at>
Archived-At: <https://www.postgresql.org/message-id/aYXcteoB-JSqP4m9%40msg.df7cb.de>
Precedence: bulk

Re: Pavlo Golub
> If we do
> 
>   WHERE last_execution_start + max_exec_time * INTERVAL '1 ms' > NOW() -
> polling_interval

Is this extra complexity worth one saved GetCurrentTimestamp()?

src/backend/access/transam/xact.c is calling GetCurrentTimestamp a
lot already, so I don't really buy the argument it should be avoided
at all cost in pg_stat_statements. Just storing the statement end time
would make this use case much nicer.

Christoph