Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 10 Feb 2026 16:14:17 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Miscellaneous message fixes
Message-ID: <aYrayZUfXKup-eEb@paquier.xyz>
References: <20260210.143752.1113524465620875233.horikyota.ntt@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="twHpAPkO+59H0c6m"
Content-Disposition: inline
In-Reply-To: <20260210.143752.1113524465620875233.horikyota.ntt@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aYrayZUfXKup-eEb%40paquier.xyz>
Precedence: bulk


--twHpAPkO+59H0c6m
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 10, 2026 at 02:37:52PM +0900, Kyotaro Horiguchi wrote:
> 0006:=20
> In extended_stats_funcs.c:
>> errmsg("could not find extended statistics object \"%s\".\"%s\"",
>>        quote_identifier(nspname),
>>        quote_identifier(stxname)));
>=20
> Since quote_identifier() already adds quoting when needed, adding
> "%s"."%s" in the format string results in double quoting. It would be
> better to use %s.%s instead.  I think quoting should be applied only
> when necessary here. I'm not sure we should use
> quote_qualified_identifier() instead.. (It's not used in the attached
> patch).
>=20
> There's a similar inconsistency.
>=20
>>	errmsg("could not clear extended statistics object \"%s\".\"%s\": incorr=
ect relation \"%s\".\"%s\" specified",
>>		   get_namespace_name(nspoid), stxname,
>>		   relnspname, relname));
>=20
> In this part, the names are not passed through quote_identifier().  It
> would be better to unify this as well.

0006 relates to some of my recent business, so I'll go look and
address this part.  Thanks for the report.=20
--
Michael

--twHpAPkO+59H0c6m
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmmK2skACgkQnvQgOdby
QH0sFQ//e+LaTEP/RfP9oaWFnUdy2eAzAGhEMP/lk4gDQl93nnZ/BA3skEWEQktI
ELnupfOcUjnAZIyqkv8bxHUBLXyvlwfQE1VS884s0rnhH7U5nU8jWhwSzDgfA3p7
rS8GHFYHclIxPM5N+JWDTj4mk/q7MH1IO94YtIOc2VPUQboQX61p4QeF8Hc32pTN
wuPhC8vwcoQvxpepwIp37PLdW4s01IzZqjvx+JNbVtQAe8m6/3sAAgoIUnKA0uRt
3e1qkyDEnkkozV91sGlvEVUNRmvkB7HLecGkgeiYF0yVLgpN9vFLK+VMu1xnCmUG
A/lTK9EcDtv5cx47jPx7MYTM8uzyM032R1bp+nGKMdrZwMbsNExdysYgbl5mJBSA
NHRzwThtESk+ha1oR3RHx7mBODB2eaUq5+BdKuXeRBeWkYfH369aLOq/sH/hw+0q
nUeS2LHiD7Ign39IK/DdDvUPZqDX4M9TxujfkqSUX72Ig9SCEnW6+mooP23S4MXB
X9L0BpRliL7ca2gE2JjIt07fiMcymRp6sR26+Z2UJ8QKMlkSgntMppdSXlT93odj
EWPUSE7z3xB03N8ycudbdfK/aw9e8PJ2l77OHKcdu5xwAmfkHiToi/HadgIfRsIW
ruu0RJR2Phbg30TmuhLjlTbd0iPyEwxB5Xktlyc/pRrjYFKdASU=
=u7Mn
-----END PGP SIGNATURE-----

--twHpAPkO+59H0c6m--