Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 11 Feb 2026 07:03:47 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: =?iso-8859-1?Q?=C1lvaro?= Herrera <alvherre@kurilemu.de>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Miscellaneous message fixes
Message-ID: <aYurQ_SLbysSvD0n@paquier.xyz>
References: <202602101023.p75nm75pl7jh@alvherre.pgsql>
 <3706800.1770735323@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Cx9g+xlLzzbB2zml"
Content-Disposition: inline
In-Reply-To: <3706800.1770735323@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/aYurQ_SLbysSvD0n%40paquier.xyz>
Precedence: bulk


--Cx9g+xlLzzbB2zml
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 10, 2026 at 09:55:23AM -0500, Tom Lane wrote:
> Yeah, this code is simply wrong.  You should remove the
> quote_identifier() calls and otherwise leave it as-is.
>=20
> quote_identifier(), quote_qualified_identifier(), etc are meant for
> building valid SQL strings.  However, an error message is a totally
> different animal.  We decided years ago that the preferred style is
> to wrap "..." around the unadorned identifier *in the error text*,
> not by using quote_identifier(), so that translators could replace
> the double-quote marks with appropriate marks for their language.
> Is the English version 100% consistent in the presence of identifiers
> containing double-quote marks?  No.  But we'd be making matters
> worse not better for other languages if we did it differently.

Right, I had a brain fart on this one.  Using "%s"."%s" where the
namespace and object names were independently quoted is also not
project style.  At the end, I have removed the quote_identifier()
calls altogether, and reduced the number of quotes in the error
strings, leading to f33c58577422 as a result.  If there is anything
else, please let me know.=20
--
Michael

--Cx9g+xlLzzbB2zml
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmmLq0MACgkQnvQgOdby
QH057Q//dfKfAFr81R04BOL7zgLd5MJgA/4pfa6iPm7Td3QwBYHSt608wMYDsgOy
Uv52UB6fdXYWAUxzhoCe+2+tyGKbvx9ze5RS+8REJRY72ww3SNkRhvzDtH5shtBz
yTmDEmPFMzDqm2uHrhn4nWPw+J9Qi/Gp8eii2oyBtMeEmNzl8XkIcXkgfQOKVTsE
hFRAsEH4jfOtT1uTlUqlGBffuOcPdV0tQ64ZWPUPejUaQUV5mB2XVIFuHtisGgxc
DUT++Fm0KNULmOOM1ja/tpelaDRFWWYFmYM1gEaC+vNK+38F4OegE/6x/bGxZTom
SAGSoguN5wkRdvCr/G1+nejtIgAjbRZ+paAp99CrZqqD2BlllyrSWuB3I6BTCep1
8yrfTJ/0Nex7uV43JXUYyT1n+Bc7+YzP73hmmGOT7K7PrrLH6X3VRhgUF1J28Mgb
CaEvK/wdem0HLhHOWlIP77yYis9f6WII+LRegDjbsalwNnCFhYYXuZrXWg8+VaBh
TD4HnxlWCgTe93mT71ec+QrVBT8YC9tMq0cewIpDVCsgnwSfdldEO60CGq48hTxv
y5k10hxtOV3dYE0ntt8xFSMH0Z7yDpQOGsSLf+3yGdoq6BVmN2hzWaizN8xyqiC8
xmB0sOZ7RWVseLCjdFylN7u9Ai8Iai6h1DYVHqSIgX48H5qoRq4=
=9fW5
-----END PGP SIGNATURE-----

--Cx9g+xlLzzbB2zml--