Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vsGvp-00E1bM-34 for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Feb 2026 08:59:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vsGvo-009Nar-2J for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Feb 2026 08:59:44 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vsGvo-009Naj-0X for pgsql-hackers@lists.postgresql.org; Tue, 17 Feb 2026 08:59:44 +0000 Received: from fhigh-b6-smtp.messagingengine.com ([202.12.124.157]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vsGvl-000000011zr-31hg for pgsql-hackers@lists.postgresql.org; Tue, 17 Feb 2026 08:59:43 +0000 Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfhigh.stl.internal (Postfix) with ESMTP id BD7337A0518; Tue, 17 Feb 2026 03:59:41 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Tue, 17 Feb 2026 03:59:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1771318781; x=1771405181; bh=WdQ6nGLk7/ iSZbDSfan+NOFrTLJwncK5XN455Tfmb3M=; b=c0R6clPzIyA6oluXRQZ5VW6lBL TS5RlEulkUFfQvgFD1daJT3g85ECgafGpxqCAXRe909e2pV5+34BtbMrspCMWnun O6himSKxFiHC3oiVvTUwIO0lVXcM9AFUxRdUp00a21IkYKct3QlbkfrYvDCF8R90 c9Gfgaz83RXYZz6SaCPiyQrsnsZ1+TDqiOOWVYZqN8yfszvAV0El9QF9u6mgbMEw IStypFuQ5u3CiD1iDTOsc/FaRZdrJrn9negpxp4ENbwXYRHg9axNGEmjLpi36AkX jPrTiwkQ4xrNUJFF8qD9HldQ/uSNTm5coHKlNaCeozARQYQnYoEFPTyEjFeA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1771318781; x=1771405181; bh=WdQ6nGLk7/iSZbDSfan+NOFrTLJwncK5XN4 55Tfmb3M=; b=niNUEp97uOWia8UAUov57xnqHxBmxjywpKpVANXboCu9TC/i57h f93Rk7H01GUm/3EPM/L3QGjPZDiu+P1K8avP1UWAp5oX5L9CE+BgOoqDMCNefj1D dK92sfvgQcLQWnEAkt+28CROOrLcMxzvAL463rGX6SGmCV8XQaqpKAuww04dXqf7 c1au8DeWZIR+fci7Rc0XlwuoMMg6hik/g1/Bj5nPK7gy2jKnxrtTgugwezYR53lv KQ4XoMGyrmdgxRIUr8MPTYEc7Q0yPdAJ4cJ+eU2fyW9X0Ps+yunLc7g3cpUF7cdM sT1T+9CvZjx0lzerbfhjfTHjmk9RVkzxQyg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvudelfeegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrh hlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeggeeg fffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiidp nhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheprghnug hrvggrshesphhrohigvghlrdhsvgdprhgtphhtthhopehtghhlsehsshhsrdhpghhhrdhp rgdruhhspdhrtghpthhtohepphhgshhqlhdqhhgrtghkvghrsheslhhishhtshdrphhosh htghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 Feb 2026 03:59:38 -0500 (EST) Date: Tue, 17 Feb 2026 17:59:31 +0900 From: Michael Paquier To: Andreas Karlsson Cc: Tom Lane , pgsql-hackers@lists.postgresql.org Subject: Re: Our ABI diff infrastructure ignores enum SysCacheIdentifier Message-ID: References: <289125.1770913057@sss.pgh.pa.us> <4653b0bf-5642-44f1-b059-7cc1db861da7@proxel.se> <1b901fbf-655d-434c-aff4-ee06313d31cd@proxel.se> <4be75b7d-587f-4217-b0ed-396949d90b43@proxel.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6dvEAZtEvkdbUT/I" Content-Disposition: inline In-Reply-To: <4be75b7d-587f-4217-b0ed-396949d90b43@proxel.se> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --6dvEAZtEvkdbUT/I Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 17, 2026 at 09:20:44AM +0100, Andreas Karlsson wrote: > Yeah, that looks like a quite nice improvement. My only comment is that if > it was me I would have split it into two patches, one introducing the > invalid and one replacing int. But you are much more familiar than me with > what granularity of commits the project prefers Splitting that into two is probably better, yes. Even if both changes touch the same portions of perl script, it makes the introduction of the two concepts cleaner. -- Michael --6dvEAZtEvkdbUT/I Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmmULfMACgkQnvQgOdby QH061g/9Ho4UEfxrtA9rReHAuY+/gEO1Bpnw7tQGn/5FhhObYE/lr2f4NU9yBVaa H2dDXHhAgYqbKDALgzX5dOMhnfQlJiwcSOgPVehWNK3xvwNgKRW2QXnhSsXMPWV5 8+8fmI5xArO+XfkqP2GqOTVAXHuiCx7MyOk6bWdhAd5OMdkDK4ituonyrniyh0WN bQMTwzS8gWaWFpM4BHCPzkprFCmcNJhteH9tIkOWwq8x2HsO0+123/c4Bxsi7R7y sc/viCbcsolhR24dn+mzfcj2zaE/NtK5INNcpyPMKENZhxAqBSK1kLkfIctCdU6b dFpJKBXjFJq64vkc9bFa/QzSO5PtS7qnX6pBLihmVFZCoFza+pF7Or+JefBpQ48V 7pie78l705l9pzGCKdyTjL5wCuUqf/qVIEothrBBn+93a+RVsrGGo8QlI4ZzciZE 34/35E9oIp7p+k8qASAirTERUr4vp1aejTVVLKoyXXcJNrAGnEaKBDlYTiB/GPnt dkyCujaTYTXVGLSope5KWV5oGVHT3iHYOw6mna+DHZxfDzX83g6NItBeVhF8+2VP faNwSU2K2t+66wPnBysZJ8oSrnwioxHJesEquSo0JcT6BmZGzg8NWrNhcG8/jQ3b JUYXNvla8k+WI24P59B9F34VNOB1CZz8hy5lI38bkAVjmU/wD5U= =36q/ -----END PGP SIGNATURE----- --6dvEAZtEvkdbUT/I--