Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 18 Feb 2026 07:30:21 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: One-off with syscache ID in get_catalog_object_by_oid_extended()
Message-ID: <aZTr_R6JGmqokUBb@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="3MzUPYm8rwZKlN7I"
Content-Disposition: inline
Archived-At: <https://www.postgresql.org/message-id/aZTr_R6JGmqokUBb%40paquier.xyz>
Precedence: bulk


--3MzUPYm8rwZKlN7I
Content-Type: multipart/mixed; boundary="B/fA0dMNuo7xFKG0"
Content-Disposition: inline


--B/fA0dMNuo7xFKG0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi all,

While reviewing the syscache code, I have bumped into the following
funny bit in objectaddress.c:
    if (oidCacheId > 0)
    {
        if (locktup)
            tuple = SearchSysCacheLockedCopy1(oidCacheId,
                                              ObjectIdGetDatum(objectId));
        else
            tuple = SearchSysCacheCopy1(oidCacheId,
                                        ObjectIdGetDatum(objectId));
        if (!HeapTupleIsValid(tuple))    /* should not happen */
            return NULL;
    }

This is wrong, because SysCacheIdentifier starts at 0.  This has no
consequence currently, because the first value in the enum is
AGGFNOID, something that we don't rely on for object type lookups.
Even if this code had the idea to use an ID of 0, the logic would just
get back to a systable lookup, that would still work, that's just less
efficient.

Simple patch attached, planned for a backpatch quickly as I am playing
with a different patch that reworks a bit this code.

Regards,
--
Michael

--B/fA0dMNuo7xFKG0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=cacheid-oneoff.patch
Content-Transfer-Encoding: quoted-printable

diff --git a/src/backend/catalog/objectaddress.c b/src/backend/catalog/obje=
ctaddress.c
index 02af64b82c68..198caf641a5e 100644
--- a/src/backend/catalog/objectaddress.c
+++ b/src/backend/catalog/objectaddress.c
@@ -2808,7 +2808,7 @@ get_catalog_object_by_oid_extended(Relation catalog,
 	Oid			classId =3D RelationGetRelid(catalog);
 	int			oidCacheId =3D get_object_catcache_oid(classId);
=20
-	if (oidCacheId > 0)
+	if (oidCacheId >=3D 0)
 	{
 		if (locktup)
 			tuple =3D SearchSysCacheLockedCopy1(oidCacheId,

--B/fA0dMNuo7xFKG0--

--3MzUPYm8rwZKlN7I
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmmU6/0ACgkQnvQgOdby
QH0rpA/9GvptRuM+4/sgILq8Sj/1wBzigmLy4+id8mbQN2gxyjqgdV58y43+Zp0n
WIQcArLNHsw5iP8SUMfGxsQ5/pshLCG1HKeyxEbPuw31f3ZGgtCILg1QJy6vsBDX
48sNqhH27WD9RnvJcFBKNHyq6Y95NbrEs8MhHHwuOxa5DjqkyONxbhSwiqFPocuZ
87act7OY6IjI9QxjOSBKzuyuvayzaBu4ByfC6QOar1Q3No/LC7jCNJ3ltxkh5D2K
0Cez8VpmXORYw48CxylSUiZFa/swv530uo9dhqRAtEkevJd90T/CELBwK0TRS+k5
ysdIXIkfKEMsKaTBQJpKlm1e2Q0CrYNBlBW6ol3xCIiEX4Cv5L61qODshIuWXg14
JL3GrxXHvLygJ1BNaSsGvi4tuX+iLDk+pezAQoRcbqZWZraXLG2CKuyJtZhJwzer
TLmYW89I4hN+62imAOQloYJNyHsuZ1lkb9wsAAO/hSFkEnrlZwhEd97h8EfNtEN3
XYLG5OkBkdYbLYcou45tiKsQGFCQBWLBUkkh/QKtUqjqg9zpJ2lH9YB5AuIPGyGM
wmn17d205RdwPXmXhA1UG36QPDKuMltXtD5KbV1RvsfsYfzVimnOL+yT0W6fhsyf
3/e372yrBbNjcRXwFlJu/4WZMpkPDdXBaqcjQl4gleBINyhNTQ8=
=+Rao
-----END PGP SIGNATURE-----

--3MzUPYm8rwZKlN7I--