Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 18 Feb 2026 11:34:19 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andreas Karlsson <andreas@proxel.se>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
Subject: Re: Our ABI diff infrastructure ignores enum SysCacheIdentifier
Message-ID: <aZUlK0NHoPucwlUc@paquier.xyz>
References: <289125.1770913057@sss.pgh.pa.us>
 <4653b0bf-5642-44f1-b059-7cc1db861da7@proxel.se>
 <aY7fvvxFG8gPdA_d@paquier.xyz>
 <1b901fbf-655d-434c-aff4-ee06313d31cd@proxel.se>
 <aZLLjKC-SS4N93bo@paquier.xyz>
 <aZQRnmp9nVjtxAHS@paquier.xyz>
 <4be75b7d-587f-4217-b0ed-396949d90b43@proxel.se>
 <aZQt88RiILCwqCMq@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="qF3uFzLW3728wETY"
Content-Disposition: inline
In-Reply-To: <aZQt88RiILCwqCMq@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/aZUlK0NHoPucwlUc%40paquier.xyz>
Precedence: bulk


--qF3uFzLW3728wETY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 17, 2026 at 05:59:31PM +0900, Michael Paquier wrote:
> On Tue, Feb 17, 2026 at 09:20:44AM +0100, Andreas Karlsson wrote:
>> Yeah, that looks like a quite nice improvement. My only comment is that =
if
>> it was me I would have split it into two patches, one introducing the
>> invalid and one replacing int. But you are much more familiar than me wi=
th
>> what granularity of commits the project prefers
>=20
> Splitting that into two is probably better, yes.  Even if both changes
> touch the same portions of perl script, it makes the introduction of
> the two concepts cleaner.

The conclusion of this exercise is that I have spotted two more spots
that checked for an invalid syscache ID based on a hardcoded value of
-1, and I have replaced them with the new value assigned in the enum.
A few more of these checked for a positive value.  There was also one
spot that I've found was incorrect, fixed separately as of
f7df12a66cc9.

The buildfarm is not complaining after c06b5b99bbb0 and ee642cccc43c,
meaning that we are hopefully good for v19 and future versions.
--
Michael

--qF3uFzLW3728wETY
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmmVJSsACgkQnvQgOdby
QH3joBAApAbZQGEY03JDgSFMLJ0Nq3w7oKNQp77vi0YKgIondwaYmBSiaYTqoEJ4
VV3OKKWNwab759KwXA7dpyCT5Fwk7loweRV39/WA6KXclmgkIgg8j6GMHW81eK57
OE0JnezL56V7tY5Igd1vNzpvuhL7kRC46gYdaF0I8QT3QBOrQEkrOHaq67U10yWb
jXGyZ/bZUctbw3ZJDh9ecI7n8/Uf1T5wWgWrn4oshnhdPPFDAvKSDwZTJiJ6DDEe
87Bc2vZ3KWAfVpKEPhcs7LDFuGDpzpdzjy4uSWJcn0ihP5jxF0A+eVym+KlHpJ5q
mRddzXriX3ATQRVyQQHQN8yPsgS1kHUfdxlhC6KleaW0OvrECDtWYsamP6IFqKHs
akylJJQGWsBXP8Yt8ft9IMplNo57EpkxG6pdfecjSnJyQus9PH1yI2V0KCA+7qR3
553o0CO+tUJUfnHXZbPwc/yRJNP6mKKOmZS11GPWrZHjxe0OCrVcooarl9F8JHNi
soep13LPLDNs6ijF6R0z2eKWvI0HtP0E+XO8s8hr4KIS9nGaM2/VzZWQdzjSTloJ
mdVpFSclM2TYWjuIXRHSocdvUak6Wjy3b+wpb2V/lFIDu/CFtSLgC7KdtIM+kaZf
hVFGpDudddPDxfp5NOUC6XYcNHsxIsR9aJn+0LUK8V8VLZId/XQ=
=Rh5M
-----END PGP SIGNATURE-----

--qF3uFzLW3728wETY--