Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 19 Feb 2026 16:02:23 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Release and unpin buffers after leaving CRIT section in GIN.
Message-ID: <aZa1fwYFD3-4BrDP@paquier.xyz>
References: <CALdSSPgBPnpNNzxv0Y+_GNFzW6PmzRZYh+_hpf06Y1N2zLhZaQ@mail.gmail.com>
 <aZQ94j8rsrkjeSZq@paquier.xyz>
 <CALdSSPj9ixr6Uf8kMs8FfcDcUWx7cQ-iysLiLJ0n-2henP1-sQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="h4rQe/+BbXdJ0wl3"
Content-Disposition: inline
In-Reply-To: <CALdSSPj9ixr6Uf8kMs8FfcDcUWx7cQ-iysLiLJ0n-2henP1-sQ@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aZa1fwYFD3-4BrDP%40paquier.xyz>
Precedence: bulk


--h4rQe/+BbXdJ0wl3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 17, 2026 at 03:14:45PM +0500, Kirill Reshke wrote:
> Looks like there are two more instances of this on HEAD: in gistbuild
> and log_newpage_range. Is it?

Planting an assertion in UnlockReleaseBuffer(), there are two extra
places that can be spotted:
- Most of the places reported by the regression tests seem to come
=66rom gistplacetopage(), with UnlockReleaseBuffer() called for a
rootsplit.  This case is actually OK to me, where the new buffers are
all unlocked with the root page locked.  I have to admit that I am not
the best specialist ever on this one, so I may be missing something.
- ginHeapTupleFastInsert(), with UnlockReleaseBuffer() called before
GinGetPendingListCleanupSize().  This one is not in line, being
registered as buffer in a XLOG_GIN_UPDATE_META_PAGE record.  We could
do better here.

Saying that, the cases of createPostingTree()@gindatapage.c, the three
in ginfast.c, the one in ginutil.c, the two in ginvacuum.c (one with
only unpins), and xloginsert.c are no-brainers to me, so I have
applied these.

The two proposed cases in gininsert.c and gistbuild.c do nothing
related to WAL-logging, though.
--
Michael

--h4rQe/+BbXdJ0wl3
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmmWtX8ACgkQnvQgOdby
QH1g7Q//QdE2BFhvDw8F2+aZJBGODjqnBu922hB8XZx7vx/PFB3IZEhVge+1BUCz
kom6uoL/nWBOujTPHMW1y1rXz5vwY1oS7AomxoBjnX5po2jopf3qE2DgrwWnSrNa
AXK3tbteHfl3F9rfz+BlNrKo5svn2XwLE0jqG7mdAEyEp1WHlOx92Ke5aXlQUXf7
RHuDVZExblVfBLGCi7a2bOEic+RwC4P5X7vScH6fe5PoDeHdOTNtyQnCAyMrhQP9
/ZP0wN8+beP58lXPWwa2lDOsGDprs16ICUiAU/mZ6yLtpmHv1H6K/gofUNllIFtC
MUJIqYwxqs5yjBXOJ0T/6fAdAd2qvEkKH/+dJD5H+H1VkRC0f5R4NwHm9Tg5gJKJ
l0U8N6yTtdv1HRZbMqPylOgj/SfKlaBb6Mqhr/HqO1FwWYLUBwE4Y2oG9WbH6GD7
8DLUDZHAKrOFHvOQppHeXUsPX6XkyXzSH7GlKHyG+0dnegsuAaJyCe+omsJWIPsR
rZVJt/LzJxsPUs0BR/8U4WXaujA06Kv905ATxryoBffFWfAYX00g40f9/YrxmS7t
EHoSwSzs5F7/uslPITCmxGqkExHyXJPWFGmJZSku683C/tICWP4mNQTAofbpsf7n
c0w0K5+ajCqo81JW/8SHM/JrdSVRmi7rikbsKBUuFs4fDFfZYbI=
=rybA
-----END PGP SIGNATURE-----

--h4rQe/+BbXdJ0wl3--