Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 19 Feb 2026 13:17:54 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Nitin Jadhav <nitinjadhavpostgres@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Change =?utf-8?B?Y2hlY2twb2ludOKAkXJl?=
 =?utf-8?Q?cord=E2=80=91missing?= PANIC to FATAL
Message-ID: <aZaO8pPLlYmcNaB2@paquier.xyz>
References: <CAMm1aWZ9Tv=Wrx52_2Ppw+6ULf_twRZuQm=ZWLA_a-kXWykHkQ@mail.gmail.com>
 <aUIoTCHzW8sdDpe_@paquier.xyz>
 <CAMm1aWb47v9Bx40P1_6YpRxxKi9XSwjAV_bLbFxx66Rg8o3+=g@mail.gmail.com>
 <aYPnGiQQAcDiUNrB@paquier.xyz>
 <CAMm1aWZQfMm1Wn=cMorqNsqdySERZCgV2JL87jVy4yCmLY8xvg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="30Ylr8DnUEDcPZQg"
Content-Disposition: inline
In-Reply-To: <CAMm1aWZQfMm1Wn=cMorqNsqdySERZCgV2JL87jVy4yCmLY8xvg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aZaO8pPLlYmcNaB2%40paquier.xyz>
Precedence: bulk


--30Ylr8DnUEDcPZQg
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 19, 2026 at 08:24:02AM +0530, Nitin Jadhav wrote:
> I had a quick look at the existing recovery TAP tests and didn=E2=80=99t
> immediately find a case where simply adding log checks would cover
> these error paths, but I=E2=80=99ll double=E2=80=91check once more before=
 sending the
> patch. I=E2=80=99ll work on this and share the patch soon.

Thanks, Nitin.  Perhaps it would be a better approach to split the
patch into multiple pieces, with the most relevant PANIC->FATAL
switches and the most critical tests on top of the rest.  It would be
nice to get most of that by the end of the release cycle, or a rather
"good" chunk of it.
--
Michael

--30Ylr8DnUEDcPZQg
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmmWjvIACgkQnvQgOdby
QH363RAAqjGn3dazDhyRgKOdZ1C6RPrhrvyJ8v4b3StTvyKC5GGfX2H2f7ETQ9Px
No5Xubv9vWrLR/pQvIGzIndJhf/wpNdNCB/P2iecwpJvEgCNemFJfKXq/zIDpDTt
KfTGFvPGMPWIurOS4e4ramOVtdMUhQ1Wt1qwnjIdIZPTlndv/hObjKHLe3dDRY8Y
fDbVDnkqutqb5DtPW2BKsm3uMdKMEj8uYL+vccvM7zN6eo5pACbrSCNicUKcgNvF
H/c50fbaKlovxQrw7gh00YjxvyNY/NF1Kn2YiJbTW/fNMIKR8LmjQVW8n4BGhEZw
/fxiiCjNgIA3AXQfkm2GKgZ0gcNyXOVJ7RCNLG6yvIGeVHQ/SXuhTF1y2kNPFcS5
0q2bS6F8mLqXsACue9v66kCU9ZbcyFsRUMAvC5aZTWXxbxQ2RHuzO9a+/M6eTIBM
BRWEah+vaXfCmfryKaicZsOJP02ZctOEetsGJRZO3KskW38UuWZTtmT+Pj2w433i
y6TWxJRfPG8wXG2CnK8eKxkB0TwvwtxiWCbMA0v5tIfivqlPen4SHX6joSRB1Pn2
zcKEjMexWiUTWRtt/8iHDg306puqF+TIAI/Hs08ofpsypFeQttbZqwGskn3+Uxtk
j5HV0ajfV8gdqzbrzL+kW0fnahszfOKPCn3uJDbeIUWsuV6GPaU=
=QhKK
-----END PGP SIGNATURE-----

--30Ylr8DnUEDcPZQg--