Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vtHLw-00DwE1-2N for pgsql-hackers@arkaria.postgresql.org; Fri, 20 Feb 2026 03:38:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vtHLv-006Mei-0p for pgsql-hackers@arkaria.postgresql.org; Fri, 20 Feb 2026 03:38:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vtHLu-006Mea-1Z for pgsql-hackers@lists.postgresql.org; Fri, 20 Feb 2026 03:38:50 +0000 Received: from fhigh-a5-smtp.messagingengine.com ([103.168.172.156]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vtHLr-00000000Ix9-1cTA for pgsql-hackers@lists.postgresql.org; Fri, 20 Feb 2026 03:38:49 +0000 Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfhigh.phl.internal (Postfix) with ESMTP id 9FC2A14001BF; Thu, 19 Feb 2026 22:38:42 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-10.internal (MEProxy); Thu, 19 Feb 2026 22:38:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1771558722; x=1771645122; bh=qS7l6JbPho X7g5srJwfQyAQbG/kvUdzNgQjL0TZjQ2A=; b=FkAXGDDCKcubXJEgKFpr3wzHO6 M9vga0NKaqGLJmhDj8h2ie8D2wwGCVRV/GAYZXTaRwk4fcDg9O6YFA3bTkQL/scc HLSRUF+WCVAzi3sNA6XAJVteD7afg4z/QICIxE3jIieIZvtucZ9j4p87fngEvA9f LEYoxJbjT2GOvu5UTpIngHfuqCBEqZjSC6mibAaTXTIacHsyk3W/EOjVOpNSblWb Kb0WQovOMjfjn4/BHu/AZ3m/+edAdp2KjufxC067vvI+XdsjYtvzvSTt9hlRPM68 N9lZUcOMwGB9VgIXNklYmye63/tKpu3KQnfMuGRGs19a7W+dp6z2n68tZ5vw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1771558722; x=1771645122; bh=qS7l6JbPhoX7g5srJwfQyAQbG/kvUdzNgQj L0TZjQ2A=; b=aELE7+9S7H6Sbt0sexoQfP1jVgCyBCbHw5XktntKI48H4P3E7p6 yXk5htomfhGJWgo+2zVTEPDHecVpQJpFo/OylAAbO6OPhDnokl2MdV9TecJ9P4yE SRw76Jj/JTLA5l+W6SWGms82fWqVoS4qvLisdC94qx5/nggjsckicShIj/UWcEfu c+IOGorv03co4buTxWOTFQre/IYQ55/xJYrr0oqtFSL7yz5FKM9ZX+7caKJWyOD5 GC+G3ETzsGIsTOX5Nliqk4/WYVaZevNV24TE/FXgRTEyHMbYr9EsPp+fopkbbLQp 4yldKKk9IRzQOCv8dZrDVgIHk0n8Bxpg9rg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvvdejfeeiucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrh hlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeggeeg fffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiidp nhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepuggrvh hiugesphhgsggrtghkrhgvshhtrdhorhhgpdhrtghpthhtohepphhgshhqlhdqhhgrtghk vghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 Feb 2026 22:38:41 -0500 (EST) Date: Fri, 20 Feb 2026 12:38:35 +0900 From: Michael Paquier To: David Steele Cc: Postgres hackers Subject: Re: Improve verification of recovery_target_timeline GUC. Message-ID: References: <08cf439a-4566-4698-b60f-d8e9ed348456@pgbackrest.org> <7c1eb8fe-7a19-43d0-84cb-9840d8bcdd14@pgbackrest.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cWPVIA4t3wb1Vt3e" Content-Disposition: inline In-Reply-To: <7c1eb8fe-7a19-43d0-84cb-9840d8bcdd14@pgbackrest.org> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --cWPVIA4t3wb1Vt3e Content-Type: multipart/mixed; boundary="VJAHnbXB7zuWXqIs" Content-Disposition: inline --VJAHnbXB7zuWXqIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 20, 2026 at 03:25:30AM +0000, David Steele wrote: > I noticed that when you replaced UINT_MAX with PG_UINT32_MAX you missed one > instance. Fixed in the attached. Added pgsql-hackers in CC for awareness, with your proposed patch attached, David. It looks so. Will fix, thanks! -- Michael --VJAHnbXB7zuWXqIs Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=uint32.patch diff --git a/src/backend/access/transam/xlogrecovery.c b/src/backend/access/transam/xlogrecovery.c index c0c2744d45b..fc794693442 100644 --- a/src/backend/access/transam/xlogrecovery.c +++ b/src/backend/access/transam/xlogrecovery.c @@ -5070,7 +5070,7 @@ check_recovery_target_timeline(char **newval, void **extra, GucSource source) if (timeline < 1 || timeline > PG_UINT32_MAX) { GUC_check_errdetail("\"%s\" must be between %u and %u.", - "recovery_target_timeline", 1, UINT_MAX); + "recovery_target_timeline", 1, PG_UINT32_MAX); return false; } } --VJAHnbXB7zuWXqIs-- --cWPVIA4t3wb1Vt3e Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmmX1zsACgkQnvQgOdby QH2NOg//WKv2D4oyVJTr2UjTuMM1N08RPcETyBAEuSsOyiXXD2yOSyloadNsMdbC YRrKXfAgnM583ManRv4J1BxwGdK50yV41/s0UkWocnJpxE2QwQSTSH5zw1GIx6f9 +GRmp3T7qj1Ls7r9OX7szB0+4Ym9LtGBBbZMLeUMzkg8DUE7EDEZeMtjpYdfALTi uaCJDaYTM0gRv2Olu2iPCRDvGZOGRyODUC6Fr2WB/6gtbAWtrF3IkTyMLJ0E4bin YTFxFqGl8bsPxaYlZlmmTWGp6lkzgo797PpPpcqh5zY1GI87BzG2ahYUU5W8DH1d hzFHODwtMvF0vxObqt+SyhWbbCuH2Ot8eDtEB9vXXnSZRZqnFuCQEC4LOHbeQekS lqsu2e5Uyp1c6/AoIiwRrtEn8IK/m4ukIhY7047pnmq6PBMCgD1FsXmxLc/X2j4A 94j4rDzmLDY9JARm4LTeLjyi8WYpJdtZ2urclPYM7bWRqDZWJCE5H90obHv3HyGE xMvU+e+5R7p9SJ3ARuCDolD+EyHxstUBNaDKxo1Hrn124oF5ny4QYy77vU6jqlyY QQecki/hrL+D6w9/Fkr2PpWNAsHWGVpHMqM6veW+9JJ59Yx9Jcktoh5ehCTb2LVI xs10AQ1WmL98JScxX8sC0kwh4WIk/erDYLuHyOlBtvEjUgMDPyg= =Dckv -----END PGP SIGNATURE----- --cWPVIA4t3wb1Vt3e--