Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vuXqG-00Cd4C-0D for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Feb 2026 15:27:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vuXqE-00DvEn-2x for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Feb 2026 15:27:22 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vuXqE-00DvEe-23 for pgsql-hackers@lists.postgresql.org; Mon, 23 Feb 2026 15:27:22 +0000 Received: from mail-oo1-xc2a.google.com ([2607:f8b0:4864:20::c2a]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1vuXqB-00000000odt-3QEw for pgsql-hackers@postgresql.org; Mon, 23 Feb 2026 15:27:21 +0000 Received: by mail-oo1-xc2a.google.com with SMTP id 006d021491bc7-6775a46c6dfso1252753eaf.2 for ; Mon, 23 Feb 2026 07:27:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771860439; x=1772465239; darn=postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GsAOOH65c2naSG9re53MYko/YLbfXSL1xWwiC3dqqu0=; b=KaEbSI+IP5mrZK7CPvTn94W85r3USdvLI0nnUbeTaeV9MxMMW+68fnVJcnTgBAkKfG QXhYmvwHJxxuOFmA6+MBHPT/B9aXZd9jOeoI8ciKYcDZCpsH4UQK+CnJoYvsDt6U/X3H mI7+WGpILj3V26RbjNpPu6KwNEk9pHpykzv689XxItkb1ubc5Txh3p/pd9eDQ+1oSlGv PjxZyvBPcV8d2RjU7dgfZMVsMTPZTHL/HNyZLolu5Veh4C/Az2pFXb5BJJQxAGiiWApT Xq2z1NYS/YE287kanOoAQNcrmsyghlJyZNtfL9zy+iyHXiGqvSe5NU3EgVmXJ+h/BZu6 oI8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771860439; x=1772465239; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GsAOOH65c2naSG9re53MYko/YLbfXSL1xWwiC3dqqu0=; b=hTrMNhekTj7h2UHQYbs3a8M3PwB/7Dur+ko7/f484CPrGcYh02aloOKD5tjgbmCFaA ccQHmsQUrKJMmnOebKDU/9eOFEwHtT+V4TIeVu6eMDJwcDvCpO6nPlAL2YT/fwv9zmLK XPHkyhHWYtKg3lwKZ8DktFJU9LYm37Z7AV3v8DZ2WMQyWpxdF/NA8Hz08rCUe/CYPVoD FheWmnISwjHNU8U6X5GT62LOtwITysqAgtgtfk45ZQlgc06IOy+vXIOIjLDwOfAGHfDW w1KbdmQa2/IWa+eWH44IIFhq9zd65eNc6pwZX13QL45yDxB3cSTTxr/pTJuylA+/XbsZ StRQ== X-Forwarded-Encrypted: i=1; AJvYcCWyZNwnJwqgjvcCYcp8wR4OpZ1XFQ+8KH+rGK5ZE7BEOBuwOjbQm/5yxxwzK2odOEY0kS7hW3gZybHdFHAv@postgresql.org X-Gm-Message-State: AOJu0Yy7F2uid107W4UC479rqHwZWcZLHA+7DiBbpE18PmeTU+/X39ha VoUea028nm9nbGAxNOfp0Xy+ouOZlQ90C+bZsDeh+M8MSmltORluDQX2 X-Gm-Gg: AZuq6aJ0BVbxQJt4G91EvyIBsiZ2Y6hPlXjDSrF3Kw0YeuQWxiv0+Ac0wk8K0msMX1F MstWXBPhTeazSPqLzF+csZW/zBCg0L18c5JKNqwE0AT4dJfePkEURLbqPgiwELDKZevvJ4X15GH mm4ZXI47TEwyq2QqC65ynpnX0Stpd/roO4g3Y03OGO5d2l2fx/6Syat3Qi6gsixQ+ALf3mfdJrk cC+KkiWznSLRYeFKHQ0GpfmteYbaVoBGbIY5eRvuUzsHN87LDMTBK/iJNrcV/UVn/sDQUM4wWhO o7o88T+ty7stu6xFqdzjNOaGncvnZ3ngicN94fPnvjRg+Ccq7W15Xgf5bm0GxV8EC7a/o2/M7lK e6rK9Y76I6Sp3YzcJ9FW0UO9v8+jK/EODj5QZ79df9tLG6dyFunw3GcjzjjBEdR8fCXw4XzB7r0 FZAHVMeErCTcSIRu3rDC02PRvj+/8PP2pbCH9LgISELiPY+bvuJpud59Jk69YwvZtXLgFQQnpYk ubccZwXxLv6HbXF X-Received: by 2002:a05:6820:2216:b0:66e:77ff:4f25 with SMTP id 006d021491bc7-679c450f83emr4075729eaf.72.1771860439591; Mon, 23 Feb 2026 07:27:19 -0800 (PST) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-679c570423fsm6215975eaf.15.2026.02.23.07.27.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 07:27:19 -0800 (PST) Date: Mon, 23 Feb 2026 09:27:17 -0600 From: Nathan Bossart To: John Naylor Cc: Greg Burd , Heikki Linnakangas , pgsql-hackers Subject: Re: refactor architecture-specific popcount code Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Feb 23, 2026 at 05:38:01PM +0700, John Naylor wrote: > +1 -- my only nitpick is "Since pg_popcount() uses a function > pointer..." is really "may use". Committed, thanks for the suggestions and for reviewing! -- nathan