Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vudYu-00GteY-2p for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Feb 2026 21:33:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vudYt-00FVYh-2e for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Feb 2026 21:33:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vudYt-00FVYX-1U for pgsql-hackers@lists.postgresql.org; Mon, 23 Feb 2026 21:33:51 +0000 Received: from mail-ot1-x336.google.com ([2607:f8b0:4864:20::336]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1vudYq-00000000rHL-2Xip for pgsql-hackers@postgresql.org; Mon, 23 Feb 2026 21:33:50 +0000 Received: by mail-ot1-x336.google.com with SMTP id 46e09a7af769-7d1872504cbso4351845a34.0 for ; Mon, 23 Feb 2026 13:33:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771882429; x=1772487229; darn=postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KfJXf4rJ7AS+U1SvLjcIK6gbrBlbVkNeFRFCVGJDTnU=; b=ND08rgOoXQeJRfkdYsnGXELyXCkYWpgaUxj8ckFPsslT6OchyQPthl8ytSwvr3OflD DWGTr2wHRA3DOCeEBoenQtRZqlfheKBsS1NbUnWGHEvYycGywDE8ebA4Qe1TolQwpxDV HSYQLIIJbbw/SfIOiUfDiECtUwbM7TpmTkXUxNJOqeZsSpXqcyf4e165ZYtLW+eTjfLW fE94aE8edAcQVlS/S0tYUb91nyb8aEoA/Hv6m+dL6nlKO0z+ypWS8JGz6j8hUrv+HP12 kcsJgD3ak2eeAazdEfmtG4LLhr7z15aW0byiDWs4rTaUx6sCTB0VYjDuEUHyJ6ua+RAM 44og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771882429; x=1772487229; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KfJXf4rJ7AS+U1SvLjcIK6gbrBlbVkNeFRFCVGJDTnU=; b=gfTuS91ZLTjlZis/t6xeq8djXKu70nLhacpUljq+l0RSp4AL/qnLdQlAzrIvxPsvsG gphm/alqP0IXNiRJJg8eRpPWCugPYoMh7o6bV1gKgfBzbIgZHkmafcgV2MbjCMSAc4Qc oXTvjEfh1FskH85GcGbtDtXvcwdqX9g03GUafyeMGPV9p4Js6OIGof7P9gm58y8njH8F SLctqOhxRy5Km1HPP3nlCM7Om3veqfKMSjueg/u0ae4oQnDAe+m8HXlMoSLczd0sWJvC oEYaw8Hrs9+AErrTB0yKDTpQQBSqOA3GrbZeMs2XlwEucwiZhyixngyrbNRemK5Ftu3G klvg== X-Forwarded-Encrypted: i=1; AJvYcCWJBzPNqZ6viQ0VauongxcnUddRK67VxFSWV6gl1wuYmwn4Ip1+q1Icw5ULu3qPtBBWtKUE6LHk92i2FF8E@postgresql.org X-Gm-Message-State: AOJu0Yz7QIYxF3MZSS2Fl7xVajXAE+XDHT86aLLbzswrXhF46RSVI0JK U01vW632n2mO4D8UYNZH3vPNGrPUT/fxlRKJbuYVAtIGu6ueiNnItU7uNQblAg== X-Gm-Gg: AZuq6aImstMbmphDSMHZedVb8og8l8nb4ZD6IOTUv8v9qMYDRSz9i95Udo2t1fKlq8o an3tqdaguraDWSp5Y027rc1/P79bkqV5OY7dSKaoh8ZwTfZQcytbVDLr3ImEBjWP3cfh8f/63Gk 7aAu/kyGFhrvdjbF11PS22uNHkLsYHik70NkqaJXjW98mbmyplugfFO9jrOuij44HrSyd03UPAu zQTBtvj8OdLnB+JQLCF2HGuybvqWhpGkys0UZrZmu0Pd0PVUNBCrzAjfJQf2qnZaLn/ti0S0wEb //xSuN8wZACfn4mz7D0pVoJfPsgfH8GK2qzKTmvDIyNS3LdiU0WrpqcYufBy9F6geaGrVLMvxvT akesNLXa+EaxtgKP7uDa6VJUTIqhD9Oie+C0nZozghusI5kKmJWCO3vrAmyDD4SmK+LJy6ZJmEd KG7k/6VYJ/Ti7XC5X97VlsgTsllPMvCQGp3D4BdsLdTm/HyIG+qIUHSPzSxy6GO7Gz30H0jGSr1 5CA2aXvK9e44KgY X-Received: by 2002:a05:6830:3591:b0:7d1:9574:db9a with SMTP id 46e09a7af769-7d52c4d6a15mr5904755a34.12.1771882428756; Mon, 23 Feb 2026 13:33:48 -0800 (PST) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d52cf78736sm8703446a34.5.2026.02.23.13.33.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 13:33:48 -0800 (PST) Date: Mon, 23 Feb 2026 15:33:46 -0600 From: Nathan Bossart To: Andres Freund Cc: Heikki Linnakangas , "pgsql-hackers@postgresql.org" Subject: Re: convert SpinLock* macros to static inline functions Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Feb 19, 2026 at 10:08:20AM -0600, Nathan Bossart wrote: > Perhaps it's still worth doing out of an abundance of caution, or maybe I > am missing something subtle about the liberties that compilers take in this > area... Committed. I ended up abandoning 0001 and adding volatile to the SpinLock* function signatures, as Andres suggested. -- nathan