Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 10 Mar 2026 15:18:58 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andreas Karlsson <andreas@proxel.se>
Cc: Rustam ALLAKOV <rustamallakov@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Add support for EXTRA_REGRESS_OPTS for meson
Message-ID: <aa-30nPkJmPKiNtl@paquier.xyz>
References: <fce84be6-3158-4b9c-9b40-a403c49d2966@proxel.se>
 <1d39c711-98cb-460f-ac44-1ab0007daeb2@proxel.se>
 <176834196488.969.13193439940284055773.pgcf@coridan.postgresql.org>
 <2b3554b9-d365-4b8a-ada1-ce81144a9c84@proxel.se>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="er57UhdotOwUL87C"
Content-Disposition: inline
In-Reply-To: <2b3554b9-d365-4b8a-ada1-ce81144a9c84@proxel.se>
Archived-At: 
 <https://www.postgresql.org/message-id/aa-30nPkJmPKiNtl%40paquier.xyz>
Precedence: bulk


--er57UhdotOwUL87C
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 14, 2026 at 02:17:30AM +0100, Andreas Karlsson wrote:
> If we add it to the documentation the question is if we should also docum=
ent
> environment variables for builds with make. But maybe that is for a separ=
ate
> patch.
>=20
> As for documenting it in testwrap: that does not feel very useful to me
> since people who know that this is where they should look likely already
> knows about these. It is a pretty hidden place. Hmm, not sure where such
> information belongs.

On point is that this also make the gap in the documentation bigger,
and if we are just doing something, why not tackle it now.  It is true
that TESTS is not documented as something that can work in meson, and
that it is not the fault of this patch, but I think that we should
spend a bit of time on the shape of an extra effort for:
1) closing the gap with the existing variables before adding more
stuff.
2) adding documentation for the new things added to testwrap, and
require that documentation is added for everything in the future.

If somebody sends a patch doing 1) for the existing things, and adds
the documentation of the new variables, satisfying 2), I would be OK
to merge the proposal (after checking it of course).

One issue for me with meson is that too many things feel implied, like
the regression test facilities that we make the effort to document for
configure/make.
--
Michael

--er57UhdotOwUL87C
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmmvt9IACgkQnvQgOdby
QH3WLQ//ZUIhpD8UaoFjZwsIWu9TA28Fce+Y7UrzmYuwzALDJraHFGEqOWk0rhr3
Hwh85qg5cgGxZvUfBFCDc1c2IHBE2BZ7JBT658KoJLRBovGjV0RoDMQ+SjaDZxH+
k4pFYVfuLoE+/QFLYPchHRP54LY5HpnY2kXMWIvx+6i5KnRKjZw4qV60XfWGgZ+j
9yJcLYy27NrtuEhfxBIkqksEj0NYPc0z6U2YIjOJQ6MXAhfl03eZdxGWDyJGbvRZ
Ev4DxCJ/oi6n8C7wY9jPJfHgmXK5gNRyYVR7AiPwuMqegEat8sjNHOXVsQDD1SsC
QxSbEJ39aOtbdbTDDdnxECrp98Oe5QIXCOB98xpAIqBZnjyuJ0FTxRF6edB5vSYi
1ps0Fm8qeK6Q9S/uoaEaY+P4G8GIfUgvnupI9Z8oZOjFPelHParVRn4ej8jePfB6
fOaps2U1vUuw+1szFvcbwwZDYdHn7hRApjPeqrcFKUfwbpzwHHaGm8chsKJNDutc
X7zMblD0R4LteZ9XJGcPxcE4XIitBZx2IlO0G6anKioD6luYYXboaNFDlA/7c0ep
LD8k7UN+ezxjy1aBr5/PornFtITKrpcGwAc/dKudKadVhTkEbXBhHEgAZIQxMFt2
mOyeYKNUFhgmUDJd2FHw1/NPzMrXuqWo2RlqpTjB/VeoqPFiz/M=
=kdHz
-----END PGP SIGNATURE-----

--er57UhdotOwUL87C--