Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 10 Mar 2026 12:58:36 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Nitin Jadhav <nitinjadhavpostgres@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Change =?utf-8?B?Y2hlY2twb2ludOKAkXJl?=
 =?utf-8?Q?cord=E2=80=91missing?= PANIC to FATAL
Message-ID: <aa-W7D-1ONpwIxwO@paquier.xyz>
References: 
 <CAMm1aWZ9Tv=Wrx52_2Ppw+6ULf_twRZuQm=ZWLA_a-kXWykHkQ@mail.gmail.com>
 <aUIoTCHzW8sdDpe_@paquier.xyz>
 <CAMm1aWb47v9Bx40P1_6YpRxxKi9XSwjAV_bLbFxx66Rg8o3+=g@mail.gmail.com>
 <aYPnGiQQAcDiUNrB@paquier.xyz>
 <CAMm1aWZQfMm1Wn=cMorqNsqdySERZCgV2JL87jVy4yCmLY8xvg@mail.gmail.com>
 <aZaO8pPLlYmcNaB2@paquier.xyz>
 <CAMm1aWZbQ-Acp_xAxC7mX9uZZMH8+NpfepY9w=AOxbBVT9E=uA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="PjIW71VUCNRN2SJI"
Content-Disposition: inline
In-Reply-To: 
 <CAMm1aWZbQ-Acp_xAxC7mX9uZZMH8+NpfepY9w=AOxbBVT9E=uA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aa-W7D-1ONpwIxwO%40paquier.xyz>
Precedence: bulk


--PjIW71VUCNRN2SJI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 06, 2026 at 11:02:41AM +0530, Nitin Jadhav wrote:
> Patch 0001 adjusts the error severity during crash recovery when the
> checkpoint record referenced by pg_control cannot be located and no
> backup_label file is present. The error is lowered from PANIC to
> FATAL. This patch also adds a new TAP test that verifies startup fails
> with a clear FATAL error. The test is straightforward: it removes the
> WAL segment containing the checkpoint record and confirms that the
> server reports the expected error.

There could be one possibility for 0001 to be unstable, actually.  One
could imagine that by getting the segment from a live server things
could fail: if the run is very slow then we may finish with an
incorrect record.  It would be possibe to use pg_controldata once the
server has been shut down, but we should be on the same segment anyway
because nothing happens on the server, so I have let the test are you
have suggested, and applied this one.  You have missed an update in
meson.build, and I am not sure that there was a need for renaming 050,
either.

> Missing checkpoint WAL segment referenced by backup_label:
> This test uses an online backup to create a backup_label file,
> extracts the checkpoint record information from it, removes the
> corresponding WAL segment, and verifies that the server reports the
> expected error.
>=20
> Missing redo WAL segment referenced by the checkpoint:
> In this test, redo and checkpoint records are forced into different
> WAL segments using injection points. A cold backup is then taken, with
> an explicit backup_label created in the restored cluster. The WAL
> segment containing the redo record is removed, and startup is expected
> to fail with the appropriate error message.

These two are very close to the existing tests that we have on HEAD
now, could it be better to group them together instead?  Particularly,
054 reuses the injection point trick in what is clearly a copy-paste
taken from 050.  Avoiding this duplication may be nice.
--
Michael

--PjIW71VUCNRN2SJI
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmmvluwACgkQnvQgOdby
QH0YDhAApkwyppwkMIbjgHWb2bz557hUkPOEIJnDrnkJEYDXZmsT182YqPq2aoXe
KhYXjzSb9lbRPby5iu8pNiU6mG8/WSaUg4RsyglOlpUwwuKCoquHI+kHrHVNptVD
DOYaee72PcZ66XYauKleTharc+SISKt+98TUVSGS0AyC+lHaGl85cbq0tj14RNsi
6jZX81qTzH200FMckBr1P3SECIMZiVHAx/cwc/HNB97rv0NyZF0VolgrO+NjoHtU
OeSmTC0EcvCuQiiCwfvzAcPjAjziXqNBZvN1DRUV3wML530LfyhNroj3Ic4JcICn
FnarwHX6IPEc30/HwigZjdmn3RkJDU5VgGzXpeXIVqwYosaiX5qOEuJQWOZKd5nO
WMf1rp8LiRP9i9FRDlTYP15Sy5DSjlf8+FUpB5Tb2XxnOCjFzGGWgZVkz9v6Pakp
QkNI1O8t16D4rKdjpyVTINcXa1a+5/3UzZC4/FRFUqTuyV/5u0KA10s5jbZ6fyqm
yYQyk55MfgFWDNAJlEuuxDZgqFyAccsNXaaifEZTJjvFG9lKmMfBVurAbaHmJ6o+
Bcsl+qYHPDm0MDlENHj7L2dcnbyMK1o/ZVf0XypkChrVIx9fy10BPl3YlVvuXN76
1aG8AuLRom5KOY/ZIrIJkgsv9HVMHVzXlYt1OG7SOL0wxhRgbrg=
=jA8W
-----END PGP SIGNATURE-----

--PjIW71VUCNRN2SJI--