Content-Type: multipart/alternative;
 boundary="------------AqBVaIDAPraxh0UB6wak0M8M"
Message-ID: <aa24964a-f0d7-435e-9254-bb69823948d6@gmail.com>
Date: Thu, 20 Nov 2025 12:46:43 +0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Add uuid_to_base32hex() and base32hex_to_uuid() built-in
 functions
To: Andrey Borodin <x4mmm@yandex-team.ru>,
 Masahiko Sawada <sawada.mshk@gmail.com>
Cc: =?UTF-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>,
 Jelte Fennema-Nio <postgres@jeltef.nl>,
 Sergey Prokhorenko <sergeyprokhorenko@yahoo.com.au>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <1791665551.452444.1761209220211.ref@mail.yahoo.com>
 <CAJ7c6TOramr1UTLcyB128LWMqita1Y7=arq3KHaU=qikf5yKOQ@mail.gmail.com>
 <18022523-0F8F-4C07-AFF5-57DC9086D78E@yandex-team.ru>
 <1895971769.8343.1761240853939@mail.yahoo.com>
 <CAD21AoCxy_3VW2_z5Rxc-tFsuqeyGsA-F_kD-tx6XXBC56nTCg@mail.gmail.com>
 <574624399.175025.1761290201491@mail.yahoo.com>
 <CAD21AoAXQcZ2mMkxX6NPdFpdC-D3AhE--qyH9Se3XTrDX6x-bg@mail.gmail.com>
 <953203149.383019.1761345585325@mail.yahoo.com>
 <CAD21AoCzEDdwpyPwA0d-QmCRe5rMz3m160SJgxMwKke85e8n0w@mail.gmail.com>
 <6F76FA61-E2DC-44EF-9504-889D9BDB4EBD@yandex-team.ru>
 <CAD21AoCKvYCccndY4CRcwk1bOuWxJionOidEtKQWoJTqS7wL1g@mail.gmail.com>
 <1154454839.957923.1761604611424@mail.yahoo.com>
 <CAGECzQTb9pg2Qw0XmOEKaJivLJ8kdGq3Cq38OqSgwiFVD=9f8A@mail.gmail.com>
 <87ldkv8cog.fsf@wibble.ilmari.org> <87ikfz7zcu.fsf@wibble.ilmari.org>
 <CAD21AoCf-0LdE=Js3ViXmKfSATJOjSNym1+80O+=-Y3X6LDMyA@mail.gmail.com>
 <9CB824CC-70DC-4165-AC6A-9664F47209EE@yandex-team.ru>
Content-Language: ru
From: =?UTF-8?B?0JjQu9GM0Y8g0KfQtdGA0LTQsNC60L7Qsg==?=
 <i.cherdakov.pg@gmail.com>
In-Reply-To: <9CB824CC-70DC-4165-AC6A-9664F47209EE@yandex-team.ru>
Archived-At: 
 <https://www.postgresql.org/message-id/aa24964a-f0d7-435e-9254-bb69823948d6%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------AqBVaIDAPraxh0UB6wak0M8M
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

31.10.2025 2:10, Masahiko Sawada wrote:
> ---
> I think we should update the documentation in the uuid section about
> casting data between bytea and uuid. For references, we have a similar
> description for bytea and integer[1].
Greetings!
I briefly tested the patched version of v3. The implemented
functionality works correctly.

---
You can also add a case with the error from v3-0002
"invalid base32hex end sequence" to the tests :

+        ereport(ERROR,
+                (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
+                 errmsg("invalid base32hex end sequence"),
+                 errhint("Input data has non-zero padding bits.")));

---
I agree with Masahiko Sawada; information about conversions
should be added to the documentation.

-- 
Best regards,
Ilya Cherdakov, PostgresPro
--------------AqBVaIDAPraxh0UB6wak0M8M
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">31.10.2025 2:10, Masahiko Sawada wrote:<span
      style="white-space: pre-wrap">
</span><span style="white-space: pre-wrap">
</span></div>
    <blockquote type="cite"
cite="mid:CAD21AoAd8smQkJWWoghBZUAQT5xk=C6mXoN99sOWo4wEdg+uLQ@mail.gmail.com">
      <pre wrap="" class="moz-quote-pre">---
I think we should update the documentation in the uuid section about
casting data between bytea and uuid. For references, we have a similar
description for bytea and integer[1].
</pre>
    </blockquote>
    Greetings!<br>
    I briefly tested the patched version of v3. The implemented <br>
    functionality works correctly.<br>
    <br>
    ---<br>
    You can also add a case with the error from v3-0002 <br>
    "invalid base32hex end sequence" to the tests :<br>
    <br>
    +        ereport(ERROR,<br>
    +                (errcode(ERRCODE_INVALID_PARAMETER_VALUE),<br>
    +                 errmsg("invalid base32hex end sequence"),<br>
    +                 errhint("Input data has non-zero padding
    bits.")));<br>
    <br>
    ---<br>
    I agree with Masahiko Sawada; information about conversions<br>
    should be added to the documentation.<br>
    <br>
    -- <br>
    Best regards,<br>
    Ilya Cherdakov, PostgresPro
  </body>
</html>

--------------AqBVaIDAPraxh0UB6wak0M8M--