Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gcARm-0000sZ-VE for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Dec 2018 14:46:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gcARj-0000OR-Dl for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Dec 2018 14:46:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gcARj-0000KB-50 for pgsql-hackers@lists.postgresql.org; Wed, 26 Dec 2018 14:46:07 +0000 Received: from mail.thelabyrinth.net ([45.56.70.56]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gcARf-0002O0-TS for pgsql-hackers@postgresql.org; Wed, 26 Dec 2018 14:46:05 +0000 Received: from Davids-MacBook.local (unknown [172.98.93.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dsteele) by mail.thelabyrinth.net (Postfix) with ESMTPSA id DA6E054625; Wed, 26 Dec 2018 14:45:59 +0000 (UTC) Subject: Re: Change pgarch_readyXlog() to return .history files first To: Michael Paquier Cc: Kyotaro HORIGUCHI , pgsql-hackers@postgresql.org References: <20181215001033.GD5012@paquier.xyz> <35420aa0-9e8b-66a2-3d69-d02cd4f8f6cf@pgmasters.net> <20181221031921.GE1886@paquier.xyz> <20181221.134918.138990251.horiguchi.kyotaro@lab.ntt.co.jp> <3c9772ef-2c75-24b9-4f5a-a7a58bc083f9@pgmasters.net> <20181221235514.GH1948@paquier.xyz> <20181224113103.GD2764@paquier.xyz> From: David Steele Message-ID: Date: Wed, 26 Dec 2018 16:45:55 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: <20181224113103.GD2764@paquier.xyz> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 12/24/18 1:31 PM, Michael Paquier wrote: > On Sat, Dec 22, 2018 at 08:55:14AM +0900, Michael Paquier wrote: >> Thanks for the lookups. I can see that the patch applies without >> conflicts down to 9.4, and based on the opinions gathered on this >> thread back-patching this stuff is the consensus, based on input from >> Kyotaro Horiguchi and David Steele (I don't mind much myself). So, >> any objections from others in doing so? > > On REL9_4_STABLE, IsTLHistoryFileName() goes missing, so committed > "only" down to 9.5. Thanks David for the patch and Horiguchi-san for > the review. Thanks, Michael! I'm not too worried about 9.4 since it is currently the oldest supported version. HA users tend to be on the leading edge of the upgrade curve and others have the opportunity to upgrade if the reordering will help them. -- -David david@pgmasters.net