Content-Type: multipart/mixed; boundary="------------yVRu8FR4PqcMaZBfCm86yKWu"
Message-ID: <aa5d88a3-71f4-3455-11cf-82de0372c941@gmail.com>
Date: Thu, 3 Nov 2022 12:34:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
From: David Geier <geidav.pg@gmail.com>
Subject: Add explicit casts in four places to simplehash.h
Content-Language: en-US
To: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/aa5d88a3-71f4-3455-11cf-82de0372c941%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------yVRu8FR4PqcMaZBfCm86yKWu
Content-Type: multipart/alternative;
 boundary="------------pVtIL9dq5aHmI1NSHtj1Tg2F"

--------------pVtIL9dq5aHmI1NSHtj1Tg2F
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi hackers,

While working on an extension, I found that simplehash.h is missing 
explicit casts in four places. Without these casts, compiling code 
including simplehash.h yields warnings if the code is compiled with 
-Wc++-compat.

PostgreSQL seems to mostly prefer omitting the explicit casts, however 
there are many places where an explicit cast is actually used. Among 
many others, see e.g.

bool.c:
     state = (BoolAggState *) MemoryContextAlloc(agg_context, 
sizeof(BoolAggState));

domains.c:
    my_extra = (DomainIOData *) MemoryContextAlloc(mcxt, 
sizeof(DomainIOData));

What about, while not being strictly necessary for PostgreSQL itself, 
also adding such casts to simplehash.h so that it can be used in code 
where -Wc++-compat is enabled?

Attached is a small patch that adds the aforementioned casts.
Thanks for your consideration!

--
David Geier
(ServiceNow)

--------------pVtIL9dq5aHmI1NSHtj1Tg2F
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta http-equiv="content-type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><font face="monospace">Hi hackers,</font></p>
    <p><font face="monospace">While working on an extension, I found
        that simplehash.h is missing explicit casts in four places.
        Without these casts, compiling code including simplehash.h
        yields warnings if the code is compiled with -Wc++-compat.</font></p>
    <p><font face="monospace">PostgreSQL seems to mostly prefer omitting
        the explicit casts, however there are many places where an
        explicit cast is actually used. Among many others, see e.g. <br>
      </font></p>
    <p><font face="monospace">bool.c:<br>
            state = (BoolAggState *) MemoryContextAlloc(agg_context,
        sizeof(BoolAggState));</font></p>
    <p><font face="monospace">domains.c:<br>
           my_extra = (DomainIOData *) MemoryContextAlloc(mcxt,
        sizeof(DomainIOData));<br>
      </font></p>
    <p><font face="monospace">What about, while not being strictly
        necessary for PostgreSQL itself, also adding such casts to
        simplehash.h so that it can be used in code where -Wc++-compat
        is enabled?</font></p>
    <p><font face="monospace">Attached is a small patch that adds the
        aforementioned casts.<br>
        Thanks for your consideration! </font>
      <style type="text/css"></style></p>
    <p><font face="monospace">--<br>
        David Geier<br>
        (ServiceNow)<br>
      </font></p>
  </body>
</html>

--------------pVtIL9dq5aHmI1NSHtj1Tg2F--

--------------yVRu8FR4PqcMaZBfCm86yKWu
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-Add-explicit-casts-to-simplehash.h.patch"
Content-Disposition: attachment;
 filename="0001-Add-explicit-casts-to-simplehash.h.patch"
Content-Transfer-Encoding: base64

RnJvbSBkMjY2NWI0MDY1MjI3ZmZhNmVmZDM3ZWU5MTJlNGFkZDA4Mjg2OWNiIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBHZWllciA8Z2VpZGF2LnBnQGdtYWlsLmNv
bT4KRGF0ZTogVGh1LCAzIE5vdiAyMDIyIDEyOjI4OjA4ICswMTAwClN1YmplY3Q6IFtQQVRD
SF0gQWRkIGV4cGxpY2l0IGNhc3RzIHRvIHNpbXBsZWhhc2guaAoKV2l0aG91dCB0aGVzZSBj
YXN0cyBjb21waWxhdGlvbiB5aWVsZHMgd2FybmluZ3Mgd2hlbiBjb21waWxpbmcgdGhlCmNv
ZGUgd2l0aCAtV2MrKy1jb21wYXQuCi0tLQogc3JjL2luY2x1ZGUvbGliL3NpbXBsZWhhc2gu
aCB8IDggKysrKy0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVs
ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2luY2x1ZGUvbGliL3NpbXBsZWhhc2guaCBi
L3NyYy9pbmNsdWRlL2xpYi9zaW1wbGVoYXNoLmgKaW5kZXggMzI5Njg3YzFhNS4uY2RmYWU1
MzdhMSAxMDA2NDQKLS0tIGEvc3JjL2luY2x1ZGUvbGliL3NpbXBsZWhhc2guaAorKysgYi9z
cmMvaW5jbHVkZS9saWIvc2ltcGxlaGFzaC5oCkBAIC00MzgsNyArNDM4LDcgQEAgU0hfQ1JF
QVRFKE1lbW9yeUNvbnRleHQgY3R4LCB1aW50MzIgbmVsZW1lbnRzLCB2b2lkICpwcml2YXRl
X2RhdGEpCiAjaWZkZWYgU0hfUkFXX0FMTE9DQVRPUgogCXRiID0gU0hfUkFXX0FMTE9DQVRP
UihzaXplb2YoU0hfVFlQRSkpOwogI2Vsc2UKLQl0YiA9IE1lbW9yeUNvbnRleHRBbGxvY1pl
cm8oY3R4LCBzaXplb2YoU0hfVFlQRSkpOworCXRiID0gKFNIX1RZUEUgKikgTWVtb3J5Q29u
dGV4dEFsbG9jWmVybyhjdHgsIHNpemVvZihTSF9UWVBFKSk7CiAJdGItPmN0eCA9IGN0eDsK
ICNlbmRpZgogCXRiLT5wcml2YXRlX2RhdGEgPSBwcml2YXRlX2RhdGE7CkBAIC00NDgsNyAr
NDQ4LDcgQEAgU0hfQ1JFQVRFKE1lbW9yeUNvbnRleHQgY3R4LCB1aW50MzIgbmVsZW1lbnRz
LCB2b2lkICpwcml2YXRlX2RhdGEpCiAKIAlTSF9DT01QVVRFX1BBUkFNRVRFUlModGIsIHNp
emUpOwogCi0JdGItPmRhdGEgPSBTSF9BTExPQ0FURSh0Yiwgc2l6ZW9mKFNIX0VMRU1FTlRf
VFlQRSkgKiB0Yi0+c2l6ZSk7CisJdGItPmRhdGEgPSAoU0hfRUxFTUVOVF9UWVBFICopIFNI
X0FMTE9DQVRFKHRiLCBzaXplb2YoU0hfRUxFTUVOVF9UWVBFKSAqIHRiLT5zaXplKTsKIAog
CXJldHVybiB0YjsKIH0KQEAgLTQ5Myw3ICs0OTMsNyBAQCBTSF9HUk9XKFNIX1RZUEUgKiB0
YiwgdWludDY0IG5ld3NpemUpCiAJLyogY29tcHV0ZSBwYXJhbWV0ZXJzIGZvciBuZXcgdGFi
bGUgKi8KIAlTSF9DT01QVVRFX1BBUkFNRVRFUlModGIsIG5ld3NpemUpOwogCi0JdGItPmRh
dGEgPSBTSF9BTExPQ0FURSh0Yiwgc2l6ZW9mKFNIX0VMRU1FTlRfVFlQRSkgKiB0Yi0+c2l6
ZSk7CisJdGItPmRhdGEgPSAoU0hfRUxFTUVOVF9UWVBFICopIFNIX0FMTE9DQVRFKHRiLCBz
aXplb2YoU0hfRUxFTUVOVF9UWVBFKSAqIHRiLT5zaXplKTsKIAogCW5ld2RhdGEgPSB0Yi0+
ZGF0YTsKIApAQCAtMTA1OSw3ICsxMDU5LDcgQEAgU0hfU1RBVChTSF9UWVBFICogdGIpCiAJ
ZG91YmxlCQlmaWxsZmFjdG9yOwogCXVpbnQzMgkJaTsKIAotCXVpbnQzMgkgICAqY29sbGlz
aW9ucyA9IHBhbGxvYzAodGItPnNpemUgKiBzaXplb2YodWludDMyKSk7CisJdWludDMyCQkq
Y29sbGlzaW9ucyA9ICh1aW50MzIgKikgcGFsbG9jMCh0Yi0+c2l6ZSAqIHNpemVvZih1aW50
MzIpKTsKIAl1aW50MzIJCXRvdGFsX2NvbGxpc2lvbnMgPSAwOwogCXVpbnQzMgkJbWF4X2Nv
bGxpc2lvbnMgPSAwOwogCWRvdWJsZQkJYXZnX2NvbGxpc2lvbnM7Ci0tIAoyLjM0LjEKCg==


--------------yVRu8FR4PqcMaZBfCm86yKWu--