Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1nCGhH-0007mP-Nn
	for pgsql-hackers@arkaria.postgresql.org; Tue, 25 Jan 2022 07:56:59 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1nCGhG-0001UI-Ks
	for pgsql-hackers@arkaria.postgresql.org; Tue, 25 Jan 2022 07:56:58 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <d.koval@postgrespro.ru>)
	id 1nCGhG-0001U3-C3
	for pgsql-hackers@lists.postgresql.org; Tue, 25 Jan 2022 07:56:58 +0000
Received: from mail.postgrespro.ru ([93.174.131.139])
	by makus.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <d.koval@postgrespro.ru>)
	id 1nCGhE-0006kK-0o
	for pgsql-hackers@lists.postgresql.org; Tue, 25 Jan 2022 07:56:57 +0000
Received: from [192.168.28.32] (cyclops.postgrespro.ru [93.174.131.138])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(Client did not present a certificate)
	by mail.postgrespro.ru (Postfix) with ESMTPSA id B317D21C8B23;
	Tue, 25 Jan 2022 10:56:53 +0300 (MSK)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru;
	s=mail; t=1643097414;
	bh=cNDeohLPDrXgBjdqoN8TGFKLEoaVKqVS6+iJdE3plCM=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To;
	b=L+PB5RUZx4GcAmqCc1Il8pLXMiwjFwIBu2kdazWuK8VuEzhwPOvkTiMpOVOIbfKTu
	 /va6wSmuQxTfyPohjWImLc8H2kTDJX66P1r3xCNj6I5vI16XevayXV7YF+gwqdgG/5
	 zKZPDILrXZHxQchkgozqLAcUK/l6NF4UWGYzhzyA=
Message-ID: <aa8db1b7-b9e8-2ef3-407b-8575ae2e9f99@postgrespro.ru>
Date: Tue, 25 Jan 2022 10:56:53 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: WIN32 pg_import_system_collations
Content-Language: en-US
To: =?UTF-8?Q?Juan_Jos=c3=a9_Santamar=c3=ada_Flecha?=
 <juanjo.santamaria@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <CAC+AXB0WFjJGL1n33bRv8wsnV-3PZD0A7kkjJ2KjPH0dOWqQdg@mail.gmail.com>
 <CAC+AXB2Znciv-r9zorGBpTPsTkq1KJY33wrkhsy1QRJ+igUrKg@mail.gmail.com>
 <20220119095312.b5ya3fvmmklnopmb@jrouhaud>
 <CAC+AXB2zm9aBUJHyXU788DgH--aog8iDbwTzpqVOkBFjcNOWPA@mail.gmail.com>
From: Dmitry Koval <d.koval@postgrespro.ru>
In-Reply-To: <CAC+AXB2zm9aBUJHyXU788DgH--aog8iDbwTzpqVOkBFjcNOWPA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/aa8db1b7-b9e8-2ef3-407b-8575ae2e9f99%40postgrespro.ru>
Precedence: bulk

Hi Juan José,

I a bit tested this feature and have small doubts about block:

+/*
+ * Windows will use hyphens between language and territory, where POSIX
+ * uses an underscore. Simply make it POSIX looking.
+ */
+ hyphen = strchr(localebuf, '-');
+ if (hyphen)
+    *hyphen = '_';

After this block modified collation name is used in function

GetNLSVersionEx(COMPARE_STRING, wide_collcollate, &version)

(see win32_read_locale() -> CollationFromLocale() -> CollationCreate()
call). Is it correct to use (wide_collcollate = "en_NZ") instead of
(wide_collcollate = "en-NZ") in GetNLSVersionEx() function?

1) Documentation [1], [2], quote:
If it is a neutral locale for which the script is significant,
the pattern is <language>-<Script>.

2) Conversation [3], David Rowley, quote:
Then, since GetNLSVersionEx()
wants yet another variant with a - rather than an _, I've just added a
couple of lines to swap the _ for a -.


On my computer (Windows 10 Pro 21H2 19044.1466, MSVC2019 version
16.11.9) work correctly both variants ("en_NZ", "en-NZ").

But David Rowley (MSVC2010 and MSVC2017) replaced "_" to "-"
for the same function. Maybe he had a problem with "_" on MSVC2010 or 
MSVC2017?

[1] 
https://docs.microsoft.com/en-us/windows/win32/api/winnls/nf-winnls-getnlsversionex
[2] https://docs.microsoft.com/en-us/windows/win32/intl/locale-names
[3] 
https://www.postgresql.org/message-id/flat/CAApHDvq3FXpH268rt-6sD_Uhe7Ekv9RKXHFvpv%3D%3Duh4c9OeHHQ%40mail.gmail.com

With best regards,
Dmitry Koval.