public inbox for [email protected]  

help / color / mirror / Atom feed
From: Michael Paquier <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: Euler Taveira <[email protected]>
Cc: Aleksander Alekseev <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: change default default_toast_compression to lz4?
Date: Fri, 27 Feb 2026 10:10:20 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<CAJ7c6TOgh15gX1ZXVEHVOBahR30pVU=HLL-30u1Rt38uxDKVkQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On Tue, Feb 24, 2026 at 10:52:39PM +0100, Peter Eisentraut wrote:
> Your patch is adding documentation for the configure option --without-lz4,
> but you are leaving the documentation for --with-lz4 in place.  You should
> delete the latter.

Ah, right.  This is what we have done for ICU in fcb21b3acdcb.  While
--with-lz4 is still allowed for backward-compatibility, we show only
--without-icu in the output of configure --help.  Reflecting the
documentation to show up the same contents as --help makes sense.

Could you update the patch, Euler?  This includes the blip in
meson.build regarding the addition of not_found_dep not really
required.
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
  download

view thread (4+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: change default default_toast_compression to lz4?
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox