Date: Fri, 27 Feb 2026 06:45:29 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, Jeff Davis <pgsql@j-davis.com>
Subject: Re: Use pg_icu_unicode_version(void) instead of
 pg_icu_unicode_version()
Message-ID: <aaE9ibod8ILJhAga@ip-10-97-1-34.eu-west-3.compute.internal>
References: <aaEhpwrj1FY/8/7n@ip-10-97-1-34.eu-west-3.compute.internal>
 <2E8E63C9-A2F6-4723-A937-B9F6CB34C88A@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2E8E63C9-A2F6-4723-A937-B9F6CB34C88A@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aaE9ibod8ILJhAga%40ip-10-97-1-34.eu-west-3.compute.internal>
Precedence: bulk

Hi,

On Fri, Feb 27, 2026 at 02:04:30PM +0800, Chao Li wrote:
> 
> 
> What I'm interested in is the broader policy: when reviewing patches,
> if we encounter a foo() declaration, should we consistently request a change to foo(void)?
> If yes, the standard should be documented somewhere.

I think that they should be consistently fixed for the reasons mentioned in 
[1], and that the best way to achieve this goal would be to enable -Wstrict-prototypes
by default ([2]).

[1]: https://postgr.es/m/aTBObQPg%2Bps5I7vl%40ip-10-97-1-34.eu-west-3.compute.internal
[2]: https://postgr.es/m/aTJ9T8HyJN3D024w%40ip-10-97-1-34.eu-west-3.compute.internal

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com