Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 27 Feb 2026 16:33:24 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Corey Huinker <corey.huinker@gmail.com>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>,
	Tomas Vondra <tomas@vondra.me>
Subject: Re: Defects with invalid stats data for expressions in extended stats
Message-ID: <aaFIxLbHgbm6Wo5m@paquier.xyz>
References: <aaDrJsE1I5mrE-QF@paquier.xyz>
 <CADkLM=c_3mPHr0JGP_72csQkpAt-v2fRN830RO8or1_R1qX2Wg@mail.gmail.com>
 <aaEctAQb8yDhqwaE@paquier.xyz>
 <92BA3F52-47FB-49F2-A156-551D7BFC326E@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="FBuQtPssWioOmJPC"
Content-Disposition: inline
In-Reply-To: <92BA3F52-47FB-49F2-A156-551D7BFC326E@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aaFIxLbHgbm6Wo5m%40paquier.xyz>
Precedence: bulk


--FBuQtPssWioOmJPC
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 27, 2026 at 02:51:40PM +0800, Chao Li wrote:
> Here stats itself is destroyed, but memory pointed by
> stats[0]~stats[i-1] are not free-ed, those memory are returned from
> examine_attribute() by palloc0_object().

I am aware of that.  This is not done on simplicity ground, keeping
the cleanup of the memory context to ANALYZE in this case.

> =E2=80=9CThis function returns sets =E2=80=A6=E2=80=9D, is =E2=80=9Cretur=
ns=E2=80=9D a typo and not needed?

That's a typo, thanks for re-reading.

> The comment says =E2=80=9Cthis function does not use a function body=E2=
=80=9D, but
> the function has a body. This appears in two places.

Let's just append a "SQL-standard" here, then.
--
Michael

--FBuQtPssWioOmJPC
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmmhSMQACgkQnvQgOdby
QH15DxAAj3//ofqvDhfD6b6yGkJXejfmVdLe3Fn7y73ntW1xQZV0zVONwp4fG3yT
VYXbDuZX3T5vwii5T04utlnPR+DW+tf3+lfDw1fJs5SExROh4XwCCelpODzXajoq
e0L/mAkH13r2j6nJDilk8uDr9tpeQbB5mh5rKcCPm6lnQNjImIj97DX6bTHH7SO3
wiIir8Hm52aIT5Sv2xsf5zFZoHYGepzHszeJMvnlAsRROqqViZ4bHYFhupPMcTpN
i7kA2cErIlVCEM1VR1muXZVLtiMnGkvIaHD3uacp3kQtLVabKPEADrKIHIDivtte
I0r+eWnYR2emr8WFpNa2GoCXdv3XVjtpLNViyHjwXyiDJYxpVDYbStyFIPfm7wpz
Himl7hzzu1MUNWSdPRWsZAo9TadI0zp8A4bhmhvZIJEmigjcQ9tzL7P5Sk0/1b+z
d3cV331ZJydv3yltWV2sxa/EmIHYImqM3UJ7xg72UuMCrlA6oDE6enOnM/u+oWmN
2t0WEF8uMJ+e+/7EcidByB6Bz2Ll28NeD42foIaWN3yuIjGARtrTSb/qcwOs9Bkh
zNYSWP+fL+M1q8RlQ1xmgWEqMkeCaKknSSqMHjIIam1rNkYoDJS0vD/nULcw3A4U
uTQJAlNFgM6Ua7HNSaLZ+hICV40m6qiLQ0Jb+jUcA+jVKxVF/8I=
=UPKp
-----END PGP SIGNATURE-----

--FBuQtPssWioOmJPC--