Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRYS9-0008VX-3e for pgsql-hackers@arkaria.postgresql.org; Wed, 31 Mar 2021 10:52:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYS8-0001Fp-0J for pgsql-hackers@arkaria.postgresql.org; Wed, 31 Mar 2021 10:52:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRYS7-0001Fg-M4 for pgsql-hackers@lists.postgresql.org; Wed, 31 Mar 2021 10:51:59 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by magus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lRYS5-0000xB-Po for pgsql-hackers@lists.postgresql.org; Wed, 31 Mar 2021 10:51:59 +0000 Received: from mail.postgrespro.ru (cyclops.postgrespro.ru [93.174.131.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id 3319721C86BC; Wed, 31 Mar 2021 13:51:56 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1617187916; bh=5qFG+52OqvmtHRYac3/f4L1dQY/s7NYsiUlu6TJJ1UA=; h=Date:From:To:Subject:In-Reply-To:References; b=O6t6VO+KAATWx6/Cty4lGvR0VLiLS7e26e0iq/TAn9liJzjucjvBvKjj90jIdV2bI QauaxX9jn6EpFC7MMx3+wKTfFk3z+sPZUYGh+Tdmx0TjPWQjnsg5+ay4n+zWiFHVoq NfmtnxRSKoYyG96M1OmHwVR+P78ORwFpVj4XSMos= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 31 Mar 2021 13:51:56 +0300 From: Maxim Orlov To: pgsql-hackers@lists.postgresql.org, masao.fujii@oss.nttdata.com Subject: Re: Failed assertion on standby while shutdown In-Reply-To: <161712624344.1180.1891286647778019120.pgcf@coridan.postgresql.org> References: <161712624344.1180.1891286647778019120.pgcf@coridan.postgresql.org> User-Agent: Roundcube Webmail/1.4.0 Message-ID: X-Sender: m.orlov@postgrespro.ru List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2021-03-30 20:44, Maxim Orlov wrote: > The following review has been posted through the commitfest > application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: not tested > Documentation: not tested > > All the tests passed successfully. > > The new status of this patch is: Ready for Committer The patch is good. One note, should we put a comment about ShutdownRecoveryTransactionEnvironment not reentrant behaviour? Or maybe rename it to ShutdownRecoveryTransactionEnvironmentOnce? --- Best regards, Maxim Orlov.