Feedback-ID: i131946ab:Fastmail
Message-ID: <aad47892-afd3-4302-41cf-257896e5bba5@enterprisedb.com>
Date: Wed, 26 Apr 2023 09:38:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.0
Subject: Re: run pgindent on a regular basis / scripted manner
Content-Language: en-US
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jelte Fennema <postgres@jeltef.nl>, Andrew Dunstan <andrew@dunslane.net>,
 "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
 Robert Haas <robertmhaas@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>,
 Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>,
 Peter Geoghegan <pg@bowt.ie>, Bruce Momjian <bruce@momjian.us>,
 Magnus Hagander <magnus@hagander.net>,
 Alvaro Herrera <alvherre@2ndquadrant.com>, Stephen Frost
 <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <CAH2-Wzm0niYBPcN6eX3PzHABfj0dE3fwifo5bdturvMp=9FGqw@mail.gmail.com>
 <4ac8f263-f1bb-faa5-a307-1fffe00f0e3e@dunslane.net>
 <CAGECzQRJrcoxozHh=BRTdLrirFui-3nvdRZru7GGa4F9HJV2Rw@mail.gmail.com>
 <b8f18576-afc0-d961-b33b-c0fa2e63edeb@dunslane.net>
 <0f074818-b01a-799f-3c74-5fb5deab1d23@dunslane.net>
 <CAGECzQSUYmfTwEWcVfwb4d=vf=M7RYJjq6ie0YPTUhP+YFcEww@mail.gmail.com>
 <1d66447e-a77b-ca0d-90a0-782800e85383@dunslane.net>
 <OSZPR01MB63100E1C06045FB66B16728BFDA09@OSZPR01MB6310.jpnprd01.prod.outlook.com>
 <e89d122e-6cf6-d0dc-8fe9-1dfa1de8dcab@dunslane.net>
 <CAGECzQSu6mLzPhd7csBfnXtW9kfoVRn5TWFH1fPGMc4mpkHyOw@mail.gmail.com>
 <3665234.1682174388@sss.pgh.pa.us>
 <e11b008e-e5f9-b31d-adbb-33ee66b49748@dunslane.net>
 <3711455.1682193493@sss.pgh.pa.us>
 <d785d648-c6e8-e273-c947-209a3ceeceb2@dunslane.net>
 <3841176.1682262970@sss.pgh.pa.us>
 <CAGECzQQH35856o4LsOF5kBAEwna_ONBcarCFcShwbh1yhXAa_w@mail.gmail.com>
 <ef2edec2-e55e-a751-a90f-5929b! 797f5c1@enterprisedb.com>
 <183836.1682345671@sss.pgh.pa.us>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <183836.1682345671@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/aad47892-afd3-4302-41cf-257896e5bba5%40enterprisedb.com>
Precedence: bulk

On 24.04.23 16:14, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
>> Does anyone find perltidy useful?  To me, it functions more like a
>> JavaScript compiler in that once you process the source code, it is no
>> longer useful for manual editing.  If we are going to have the buildfarm
>> check indentation and that is going to be extended to Perl code, I have
>> some concerns about that.
> 
> I certainly don't like its current behavior where adding/changing one
> line can have side-effects on nearby lines.  But we have a proposal
> to clean that up, and I'm cautiously optimistic that it'll be better
> in future.  Did you have other specific concerns?

I think the worst is how it handles multi-line data structures like

         $newnode->command_ok(
             [
                 'psql', '-X',
                 '-v',   'ON_ERROR_STOP=1',
                 '-c',   $upcmds,
                 '-d',   $oldnode->connstr($updb),
             ],
             "ran version adaptation commands for database $updb");

or

         $node->command_fails_like(
             [
                 'pg_basebackup',   '-D',
                 "$tempdir/backup", '--compress',
                 $cft->[0]
             ],
             qr/$cfail/,
             'client ' . $cft->[2]);

Perhaps that is included in the upcoming changes you are referring to?