Subject: Re: very long record lines in expanded psql output
To: Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <f03d38a3-db96-a56e-d1bc-dbbc80bbde4d@gmail.com>
 <CAFj8pRBJ8bcTga9qTYG_v25BfeCB=4+GNc1rbf94qex_3C_e-A@mail.gmail.com>
 <998a8549-f808-a349-bae6-9f44d07e050d@dunslane.net>
 <d5280c71-b11b-b0fc-f57d-5033a9197406@gmail.com>
 <bf64d7b0-413d-1501-00b2-992491b865b0@dunslane.net>
 <4e8b9a10-95aa-aecf-01a1-cbc24d643465@gmail.com>
 <66d23848-9f73-abc9-2fbb-3b8abfbb2fce@dunslane.net>
 <0efd52b9-450a-7636-fb75-663bc2d81b34@gmail.com>
 <92258bb8-8b9d-8f70-6f34-b5499215204c@dunslane.net>
From: Platon Pronko <platon7pronko@gmail.com>
Message-ID: <aae2bfe7-e07f-bb11-5d5a-529e76e0f317@gmail.com>
Date: Mon, 23 Aug 2021 20:51:24 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <92258bb8-8b9d-8f70-6f34-b5499215204c@dunslane.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/aae2bfe7-e07f-bb11-5d5a-529e76e0f317%40gmail.com>
Precedence: bulk

Hi!

Please find attached the patch implementing the proposed changes.
I hope I didn't forget anything (docs, tab completion, comments, etc),
if I did forget something please tell me and I'll fix it.

Best regards,
Platon Pronko

On 2021-08-08 01:18, Andrew Dunstan wrote:
> 
> On 8/7/21 10:56 AM, Platon Pronko wrote:
>> Hi!
>>
>>>>>>> I also find this annoying and would be happy to be rid of it.
>>>>>>
>>>>>> Have you tried "\pset format wrapped"? Pavel suggested it, and it
>>>>>> solved most of the problem for me, for example.
>>>>>
>>>>> Yes, but it changes the data line output. Ideally, you should be able
>>>>> to  modify these independently.
>>>>
>>>> I agree, and I think this can be implemented, but I'm a bit afraid of
>>>> introducing an additional psql option (there's already quite a lot of
>>>> them).
>>>> I suspect primary PostgreSQL maintainers won't be happy with such an
>>>> approach.
>>>>
>>>>
>>>
>>> I think I qualify as one of those ... :-)
>>
>> Sorry, I'm new here, don't know who's who :)
> 
> 
> No problem. Welcome! We're always very glad to see new contributors.
> 
> 
>>
>> I'll start working on a new patch then. A couple questions about
>> specifics:
>>
>> 1. Can we add "expanded" in the option name, like
>> "xheader_expanded_width"?
>> I think adjusting the header row width doesn't make sense on any other
>> modes,
>> and placing that in the option name makes intent a bit clearer.
> 
> 
> 
> "xheader" was meant to be shorthand for "expanded output header"
> 
> 
>>
>> 2. What was "column" option in your original suggestion supposed to do?
>> ("\pset xheader_width column|page|nnn")
> 
> 
> It's meant to say don't print anything past the column spec, e.g.:
> 
> 
> -[ RECORD 1 ]----+
> n                | 42
> long_column_name | xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
> -[ RECORD 2 ]----+
> n                | 210
> long_column_name | xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
> 
> 
>>
>> 3. Should we bother with using this option when in "\pset border 2" mode?
>> I can do it for consistency, but it will still look bad.
>>
>>
> 
> Probably not, but since I never use it I'll let others who do weigh in
> on the subject.
> 
> 
> cheers
> 
> 
> andrew
> 
> 
> --
> Andrew Dunstan
> EDB: https://www.enterprisedb.com
>