Subject: Re: WIP: System Versioned Temporal Table
To: Surafel Temesgen <surafel3000@gmail.com>
Cc: Simon Riggs <simon.riggs@enterprisedb.com>,
 Ryan Lambert <ryan@rustprooflabs.com>,
 Masahiko Sawada <sawada.mshk@gmail.com>,
 Michael Paquier <michael@paquier.xyz>, =?UTF-8?Q?R=c3=a9mi_Lapeyre?=
 <remi.lapeyre@lenstra.fr>, Eli Marmor <eli@netmask.it>,
 David Steele <david@pgmasters.net>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
 Georgios <gkokolatos@protonmail.com>
References: <b11fa573-38fa-ba57-96a9-e4dd9ce3fb76@2ndquadrant.com>
 <CAD21AoAUDJj_y_5fH5FLBLUDTZa579jbE5Y12SQz4nJh-RVx7A@mail.gmail.com>
 <CANbhV-EZu-SHXERZ=Bbq5g+ePi7QUX_0WgLtRsove_Jiigtaaw@mail.gmail.com>
 <CANbhV-EOTSc2EWS_LKiXKgLqnrjtaU0hf3Rzxn111nir6Pn4zA@mail.gmail.com>
 <CANbhV-ECkPhsXEtj7gYFjXCdq+3WTiHo9XkF5wQmFOj4w+YTaw@mail.gmail.com>
 <CANbhV-Fb35HMoySGMFfcxN_3i45Bb6cZODOcz8S7+Nys3Y2raA@mail.gmail.com>
 <CAN-V+g-D7bObC3m5rcm3zr8MmTVE4_OVJuEp8Qse0ZgE4PAhsw@mail.gmail.com>
 <CALAY4q_YgDZSSHsyDAv2gY73GyWjt5V+DNUha3gL13dk9EepOw@mail.gmail.com>
 <CANbhV-HXDvOZL5xfHBh3KpXffpLwOwf5GRO405RP8e6DtK1rvQ@mail.gmail.com>
 <CALAY4q8Pp699qv-pJZc4toS-e2NzRJKrvaX-xqG1aqj2Q+Ww-w@mail.gmail.com>
 <CANbhV-G33om-YEALmhB-CNNw5fnfLAzQZu+MT55oJbwm=tpe+g@mail.gmail.com>
 <CALAY4q-MGmStgenU_fA0XHkkXdHy64r8d1kAfbs+1TT912zMhw@mail.gmail.com>
 <7764ee7b-bb28-63a3-0462-34b2d8a2e107@postgresfriends.org>
 <CALAY4q-AOyjFHqMFVAo8uN30_T2+8Ex0yrP9weygo04qRtb02w@mail.gmail.com>
From: Vik Fearing <vik@postgresfriends.org>
Message-ID: <aae2d4a8-9d58-6e42-ef4b-b9da0f5fef91@postgresfriends.org>
Date: Sun, 17 Jan 2021 23:42:59 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: 
 <CALAY4q-AOyjFHqMFVAo8uN30_T2+8Ex0yrP9weygo04qRtb02w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/17/21 5:46 PM, Surafel Temesgen wrote:
> On Sat, Jan 16, 2021 at 10:12 PM Vik Fearing <vik@postgresfriends.org>
> wrote:
> 
>>
>> I haven't looked at this patch in a while, but I hope that ALTER TABLE t
>> ADD SYSTEM VERSIONING is not adding any columns.  That is a bug if it does.
>>
>>
> Yes, that is how I implement it. I don't understand how it became a bug?

This is not good, and I see that DROP SYSTEM VERSIONING also removes
these columns which is even worse.  Please read the standard that you
are trying to implement!

I will do a more thorough review of the functionalities in this patch
(not necessarily the code) this week.
-- 
Vik Fearing