Message-ID: <aaeab7d1-bfda-5753-30f0-4b544fd4b9aa@enterprisedb.com>
Date: Fri, 25 Mar 2022 20:58:11 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: logical decoding and replication of sequences
Content-Language: en-US
To: vignesh C <vignesh21@gmail.com>
Cc: Petr Jelinek <petr.jelinek@enterprisedb.com>,
 Amit Kapila <amit.kapila16@gmail.com>,
 Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <d045f3c2-6cfb-06d3-5540-e63c320df8bc@enterprisedb.com>
 <f242d058-be79-6a59-5497-0bb256cafcc7@enterprisedb.com>
 <e890448d-00b5-18d0-e894-85d17660d484@enterprisedb.com>
 <9defb937-20a9-1d9f-6972-f1c4b4da4f73@enterprisedb.com>
 <8e766e0f-ed3e-fd68-4b0f-10dd2db60c88@enterprisedb.com>
 <c38fd4df-f71a-cf47-88cd-5f486b5bca92@enterprisedb.com>
 <f64b0ecd-0723-c70d-8ec5-2b5c0e476a50@enterprisedb.com>
 <6b21233e-c880-e4ad-5df2-7832f769296c@enterprisedb.com>
 <9da788c7-01eb-f11d-aa08-c5f61fe9f33a@enterprisedb.com>
 <CAA4eK1Jro8hGX_hzXCznBr++suoDM7avEhFtiphPeDLPBOc=Ow@mail.gmail.com>
 <456A528F-8F19-41C7-9857-927024D32396@enterprisedb.com>
 <CAA4eK1Jn-DttQ=4Pdh9YCe1w+zGbgC+0uR0sfg2RtkjiAPmB9g@mail.gmail.com>
 <BDDB28EE-84D3-4BA8-A5BD-DFF56CE584BC@enterprisedb.com>
 <aeb2ba8d-e6f4-5486-cc4c-0d4982c291cb@enterprisedb.com>
 <74729cc5-960b-9295-912a-a7c37356a0c4@enterprisedb.com>
 <CALDaNm3q_9AnXPwQ8fOod2=OhsB4Bz9UYrxOJ1Jnq85pZWXhnQ@mail.gmail.com>
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
In-Reply-To: 
 <CALDaNm3q_9AnXPwQ8fOod2=OhsB4Bz9UYrxOJ1Jnq85pZWXhnQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/aaeab7d1-bfda-5753-30f0-4b544fd4b9aa%40enterprisedb.com>
Precedence: bulk

On 3/25/22 15:34, vignesh C wrote:
> On Fri, Mar 25, 2022 at 3:29 AM Tomas Vondra
> <tomas.vondra@enterprisedb.com> wrote:
>>
>> Hi,
>>
>> Pushed, after going through the patch once more, addressed the remaining
>> FIXMEs, corrected a couple places in the docs and comments, etc. Minor
>> tweaks, nothing important.
> 
> While rebasing patch [1] I found a couple of comments:
> static void
>  ObjectsInPublicationToOids(List *pubobjspec_list, ParseState *pstate,
> -    List **rels, List **schemas)
> +    List **tables, List **sequences,
> +    List **tables_schemas, List **sequences_schemas,
> +    List **schemas)
>  {
>   ListCell   *cell;
>   PublicationObjSpec *pubobj;
> @@ -185,12 +194,23 @@ ObjectsInPublicationToOids(List
> *pubobjspec_list, ParseState *pstate,
>   switch (pubobj->pubobjtype)
>   {
>   case PUBLICATIONOBJ_TABLE:
> - *rels = lappend(*rels, pubobj->pubtable);
> + *tables = lappend(*tables, pubobj->pubtable);
> + break;
> + case PUBLICATIONOBJ_SEQUENCE:
> + *sequences = lappend(*sequences, pubobj->pubtable);
>   break;
>   case PUBLICATIONOBJ_TABLES_IN_SCHEMA:
>   schemaid = get_namespace_oid(pubobj->name, false);
> 
>   /* Filter out duplicates if user specifies "sch1, sch1" */
> + *tables_schemas = list_append_unique_oid(*tables_schemas, schemaid);
> + *schemas = list_append_unique_oid(*schemas, schemaid);
> + break;
> 
> Now tables_schemas and sequence_schemas are being updated and used in
> ObjectsInPublicationToOids, schema parameter is no longer being used
> after processing in ObjectsInPublicationToOids, I felt we can remove
> that parameter.
> 

Thanks! That's a nice simplification, I'll get that pushed in a couple
minutes.

>   /* ALTER PUBLICATION <name> ADD */
>   else if (Matches("ALTER", "PUBLICATION", MatchAny, "ADD"))
> - COMPLETE_WITH("ALL TABLES IN SCHEMA", "TABLE");
> + COMPLETE_WITH("ALL TABLES IN SCHEMA", "ALL SEQUENCES IN SCHEMA",
> "TABLE", "SEQUENCE");
> 
> Tab completion of alter publication for ADD and DROP is the same, we
> could combine it.
> 

We could, but I find these combined rules harder to read, so I'll keep
the current tab-completion.

> Attached a patch for the same.
> Thoughts?

Thanks for taking a look! Appreciated.

> 
> [1] - https://www.postgresql.org/message-id/CALDaNm3%3DJrucjhiiwsYQw5-PGtBHFONa6F7hhWCXMsGvh%3DtamA%40mail.gmail.com
> 

regars

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company