Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 4 Mar 2026 13:09:40 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Euler Taveira <euler@eulerto.com>,
	Aleksander Alekseev <aleksander@tigerdata.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: change default default_toast_compression to lz4?
Message-ID: <aaewhB2T4S7nD4bX@paquier.xyz>
References: <435df33a-129e-4f0c-a803-f3935c5a5ecb@eisentraut.org>
 <aSaDfIrZIhZwAe42@paquier.xyz>
 <c822b84c-b104-4fb4-92f3-3008cce50bf9@app.fastmail.com>
 <CAJ7c6TOgh15gX1ZXVEHVOBahR30pVU=HLL-30u1Rt38uxDKVkQ@mail.gmail.com>
 <c269e7e1-2ef0-4fb2-8ecd-18ab2db13e3b@app.fastmail.com>
 <aTJCI6Ej8I0iuZmD@paquier.xyz>
 <92ed55b6-6b69-42d9-8697-3e51603e961d@app.fastmail.com>
 <7267cdf8-f270-4cb1-9713-43c92cffe179@eisentraut.org>
 <aaDu_Oa2yq19TAoF@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="MFupluhisR7Qt8rM"
Content-Disposition: inline
In-Reply-To: <aaDu_Oa2yq19TAoF@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/aaewhB2T4S7nD4bX%40paquier.xyz>
Precedence: bulk


--MFupluhisR7Qt8rM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Feb 27, 2026 at 10:10:20AM +0900, Michael Paquier wrote:
> Ah, right.  This is what we have done for ICU in fcb21b3acdcb.  While
> --with-lz4 is still allowed for backward-compatibility, we show only
> --without-icu in the output of configure --help.  Reflecting the
> documentation to show up the same contents as --help makes sense.

It would have been a waste to not see this change happening, so I have
looked a bit more in depth at it.  You are right that we should remove
the reference to --with-lz4, but it seems to me that this should apply
to all the references of the switch we have in the docs.  The change
in meson.build was not necessary.  Another thing not yet included was
the mandatory autoreconf.  With all that done, applied.

Now, let's see how much this breaks the buildfarm..  Because things
will break.  I'll send a poke to the buildfarm mailing list.
--
Michael

--MFupluhisR7Qt8rM
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmmnsIQACgkQnvQgOdby
QH2mEhAAniv+Y+gnDcTUzEHuU1Qo09ITmM4PSDjckeK3/PW446Q2qHweANNJPc/b
+bYVVg/w5J9OXAO1hUQMA/YILDPqmXJ9lKDsmLBcvMZbkdwZCZxtQwRIwapp2mp+
ILRPzTS+TovZ32r3eQCbgXaxxay9/gQSZ+N7SxqbvLsfdrf34pUOXhYP6eUBHdDP
V+JuXMBdOahDZs4x5KP44pJiTAlHoFV4fMkr5emw5rLg7V4+BLf8n12yB6Bct1qp
OG2ozCetHL8GPPU6x2QnaONHfEP6o5bqdnRS+ZV6s2Ez/IySfYy3+FBRsFOXN8G9
giTZqfdg9lDECtmwi0YD+t0b2LluHzkaAsmwqoZRlOg5GVP9W+MTGMPjQ5c/R7oZ
t8eDSb5m07S/lbAttCKwORKiOSZ9OgawlJIbcg7M9c/3Xvh8aJ2V/tH3+AVeKxeJ
qThBwBhweLsGhY+xZ+sMyDa9O2iKjoxpqedoMmaAA/e6jaEMetC3zDq3tY8+75lf
oOtpgbVXw3cds5pINpv9gnmi3T9HyutiApY1HwQnXj5wTpYx5ZBYabpw6kpvBnW1
Su5thkgdx/kEt3U1mcUKAf5auIKPP/+dFuYNPYdrgLdhCK9ErjN8nP4n9DBvn6Cc
o5tjj/G+KaqE1mpWOrkk80AM/52CNKGhkkZCrcC1ZHXslXqFylM=
=OPXg
-----END PGP SIGNATURE-----

--MFupluhisR7Qt8rM--