Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 4 Mar 2026 15:30:58 +0900
From: Michael Paquier <michael@paquier.xyz>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: 'Alexander Lakhin' <exclusion@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	Aleksander Alekseev <aleksander@timescale.com>
Subject: Re: BUG: Former primary node might stuck when started as a standby
Message-ID: <aafRom_SDdZXeIKG@paquier.xyz>
References: 
 <OS9PR01MB12149D4F1A2BC23637688CE4DF56BA@OS9PR01MB12149.jpnprd01.prod.outlook.com>
 <045cab6f-4738-417e-b551-01adba44d6c3@gmail.com>
 <c7284102-01fb-4704-8a80-8e65f59fa933@gmail.com>
 <aaU5EiNHfyMb9Bvu@paquier.xyz>
 <TYRPR01MB12156CC5A9AC774B07FA7E40BF57FA@TYRPR01MB12156.jpnprd01.prod.outlook.com>
 <aaZ77VvZ4Oabp30A@paquier.xyz>
 <493401a8-063f-436a-8287-a235d9e065fc@gmail.com>
 <OS9PR01MB121491FE3BD5D9D7341B83537F57FA@OS9PR01MB12149.jpnprd01.prod.outlook.com>
 <aafDsb5snkfkNfdS@paquier.xyz>
 <aafRT3EJOS274tw1@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="JkqBI624jl5THtZz"
Content-Disposition: inline
In-Reply-To: <aafRT3EJOS274tw1@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/aafRom_SDdZXeIKG%40paquier.xyz>
Precedence: bulk


--JkqBI624jl5THtZz
Content-Type: multipart/mixed; boundary="V8WgjJeMx8hg9gCB"
Content-Disposition: inline


--V8WgjJeMx8hg9gCB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Mar 04, 2026 at 03:29:35PM +0900, Michael Paquier wrote:
> I'll push this fix shortly, taking care of one instability.  Nice
> investigation on this one, Alexander, by the way.

With the patch attached, for reference..
--
Michael

--V8WgjJeMx8hg9gCB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=2pc-tap-fix.patch
Content-Transfer-Encoding: quoted-printable

diff --git a/src/test/recovery/t/009_twophase.pl b/src/test/recovery/t/009_=
twophase.pl
index 879e493b5b83..aa73d3e106c5 100644
--- a/src/test/recovery/t/009_twophase.pl
+++ b/src/test/recovery/t/009_twophase.pl
@@ -222,7 +222,7 @@ $cur_primary->psql(
 	SAVEPOINT s1;
 	INSERT INTO t_009_tbl VALUES (22, 'issued to ${cur_primary_name}');
 	PREPARE TRANSACTION 'xact_009_10';");
-$cur_primary->teardown_node;
+$cur_primary->stop;
 $cur_standby->promote;
=20
 # change roles

--V8WgjJeMx8hg9gCB--

--JkqBI624jl5THtZz
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmmn0aIACgkQnvQgOdby
QH36cQ//QYI4IOnUdwAgbj0D/kv0OS6YI2TBWunXGZfYaEqEqgcgAUmDlLAjsx+B
J8XgQd7SFrooM27a4OMl+Cgjw4GrMbkPUkfxwpLC8AIJ6dyZLCdOaZHzG3JEijRQ
0ZSAYuSMKDDIPzy6dYFEXE645qjmVph0QmjHkWHXcuo6Xnrv9/Dby2DJQYbRimJK
VAFR1DeEWI2whr7qbzoSe/4XTuxVzXlG6VlgLHxXik7xcMxgdZB5trDHl48PmJfS
34ylMCMxhQRDcINYMSkB5qZ/nSwVqrJlYV0vh4SZMeUktnzXtvNiUwnOukKXthb5
9QHuiQHtM4YSkRCxsD5YGohZP4VhS62YrbD3wvrjfut7wRo9JZD1NF6syhnooRQ8
FJCTIouInliZyToTSNW0ifxsLJ6G7cyMF8Vh77dQ0XsWFdyMZ0HQuguFmDKfXj2r
l+MAfunbzZ0i2nE+LJZnlFRpP5codYGJWqySzRI4ycC/BNwX576g9b6ajNTJ9L+f
tt7oz1iGIuvVdSPzbLqg6tADLNRhtIgB1miv8h9tfSbpBT6axcEo5v0w2vnnS6vd
mZrT8It6/HM7DViBDpuFH0IUOtsmv9EL1+tXe0yHw6Vk0NsVhQZherOAPuAzSeMe
YgSxJyGgjdNF3j+N5XL+dnZq/bXao2W6Ix0qRdiRwFs6Fald7bI=
=jATa
-----END PGP SIGNATURE-----

--JkqBI624jl5THtZz--