Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 5 Mar 2026 13:03:36 +0900
From: Michael Paquier <michael@paquier.xyz>
To: David Steele <david@pgbackrest.org>
Cc: Fujii Masao <masao.fujii@gmail.com>,
	=?iso-8859-1?Q?H=FCseyin?= Demir <huseyin.d3r@gmail.com>,
	Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Improve checks for GUC recovery_target_xid
Message-ID: <aakAmNjKyBWRU1vR@paquier.xyz>
References: <f14463ab-990b-4ae9-a177-998d2677aae0@pgbackrest.org>
 <CAHGQGwEnakTrosMp3Y=Trya4MTC-h8Lqx3FDU1mOALRQ0rz59Q@mail.gmail.com>
 <9e8b7ee9-4a16-477a-baa5-0cdf37a04798@pgbackrest.org>
 <CAHGQGwG44vZbSoBmg076G+xkR6n=Tj2=q+fVkfP7yEsyF1daFA@mail.gmail.com>
 <c2e97e35-1227-4351-8faa-fa95208f6cf9@pgbackrest.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="BTmk514iskls48GL"
Content-Disposition: inline
In-Reply-To: <c2e97e35-1227-4351-8faa-fa95208f6cf9@pgbackrest.org>
Archived-At: 
 <https://www.postgresql.org/message-id/aakAmNjKyBWRU1vR%40paquier.xyz>
Precedence: bulk


--BTmk514iskls48GL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 05, 2026 at 03:40:44AM +0000, David Steele wrote:
> I wrote the tests for recovery_target_timeline but I was not too satisfied
> with them because starting Postgres is fairly expensive.

+# Invalid recovery_target_xid tests
+$node_standby = PostgreSQL::Test::Cluster->new('standby_10');
+$node_standby->init_from_backup($node_primary, 'my_backup',
+    has_restoring => 1);
+$node_standby->start;
+
+my ($result, $stdout, $stderr) = $node_primary->psql('postgres',
+    "ALTER SYSTEM SET recovery_target_xid TO 'bogus'");
+like(
+    $stderr,
+    qr/is not a valid number/,
+    "invalid recovery_target_xid (bogus value)");

Smart move to rely on ALTER SYSTEM to check how the GUC callback is
reacting on incorrect input values.  Why do you need to create and
start a new standby if it is not used, then?
--
Michael

--BTmk514iskls48GL
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmmpAJgACgkQnvQgOdby
QH1SOg/9FgdBxMFkiYasQNgAKqkqHOjuvZYsKm0EQfzJL0ZIgPGjZZvA5N/nNACu
3MebxXniBuguNDrBSqHwp+OC9QRR2w/PdHaMwVHAJv+AE2CjgdMFrlxmoyHdIx9p
nTQmP7usY7v/xGJTTrvYmLsEuY7sekkVP3R6oM8fyCW+QChmEwU3hEiP+0qcPZTL
WIC7C78JxgHh7LUdqv6mXDR/8+IRQPOjpE5iwXheyzpudbnkaJ8pdYo4ZjrSl59R
LASagHIHq+0C0scYZMRNhS7BOYl0JKH1A+QJPllKFMGqe2Qeu7Y31CKRQHK0bsBj
v8uWjUFsTciNoekruDPi7eg+oQ+hP4V1f4Xs7vHFtKXygmDjfgBYu4dBxh6ooMVd
ld/nNQnKB6gXuy/219mSD7rIKAVvs3WA70u/8NH1sIBPq4DLH7r+8uOY/7OUv6Xl
A2ykmvoVsGDq78Syj9U/MV1/tyRrkvREIyUNk9ooNECh/cI9fOGUDuvJnWguiMmS
Ml1HGNe1IajF/XZmIhA6E7y4BMVmn11Dreaj3EmkKYsAVSkeOYW7oBDwSwsY5hXD
cjzHv9Uiat+sOJVFZ7hTlkL1+gV7Z/GwpvEjLSxozKM3DDuvLvP1aAWFlYVAjPEf
CZE98spBxs+UiVEA+pSDrXy/jF+ms53cwmZSwbPwQBwa6/unGoE=
=Fpjx
-----END PGP SIGNATURE-----

--BTmk514iskls48GL--