Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1sUVIg-003X7X-Jz
	for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Jul 2024 17:52:18 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1sUVIe-002BTW-Ns
	for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Jul 2024 17:52:17 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1sUVIe-002BTO-EW
	for pgsql-hackers@lists.postgresql.org; Thu, 18 Jul 2024 17:52:16 +0000
Received: from oss.nttdata.com ([49.212.34.109])
	by magus.postgresql.org with esmtps  (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1sUVIc-000EzA-MF
	for pgsql-hackers@lists.postgresql.org; Thu, 18 Jul 2024 17:52:16 +0000
Received: from [192.168.11.3] (p4227034-ipxg13801funabasi.chiba.ocn.ne.jp
 [122.26.176.34])
	by oss.nttdata.com (Postfix) with ESMTPSA id 99C93619AD;
	Fri, 19 Jul 2024 02:52:10 +0900 (JST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.11 at oss.nttdata.com
Message-ID: <ab3128a9-2689-49b5-bf8a-99c74f4f0473@oss.nttdata.com>
Date: Fri, 19 Jul 2024 02:52:10 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Add a GUC check hook to ensure summarize_wal cannot be enabled
 when wal_level is minimal
Content-Language: en-US
To: Robert Haas <robertmhaas@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
 pgsql-hackers@lists.postgresql.org
References: 
 <CA+TgmoansG0B8ayQGw9Ozee6Jawz=HFUACpO_4gp-+SFJBxiYw@mail.gmail.com>
 <CA+TgmoZ53ADUm2UAGEspMuv-Db5SGtrOXUx=ps6LcGexsf5-fA@mail.gmail.com>
 <e2549085-5246-4edc-bc62-ae19df48acc5@oss.nttdata.com>
 <CA+TgmoYFOWbxk=FP+ZnxwVaKQEce=+0Xvzh0DUC9=YLNHiQW1w@mail.gmail.com>
 <8a668c51-c6af-4744-a978-c6a2ce3b1d83@oss.nttdata.com>
 <CA+TgmoYUhRa8j8_Jdrb9Ankz=c8NRLe_x1nf4L+Vc2V+DiTSWw@mail.gmail.com>
 <ZpVushkGx0_nYIip@nathan>
 <CA+TgmoaKqLrkjEg1j6NEHcMUj-Qk6yUK=qfFzy+G-w6OVVv+0Q@mail.gmail.com>
 <ZpWCJxL3tQm3lkLI@nathan>
 <CA+TgmobLzdVQCjy9abec-UFrN1SmwHGv9WcaOD_XixmJN5e+=A@mail.gmail.com>
 <ZpagGUyMkwg-LeKC@nathan>
 <22585eb0-4a10-4d99-9914-bdee011e8778@oss.nttdata.com>
 <CA+Tgmob6MSyKPQQ2QfKVznLHz1-Dg2AoZxjUoz80PTYXq14gRw@mail.gmail.com>
 <6b210ab2-750c-41fd-8954-d5fd0f1d4437@oss.nttdata.com>
 <CA+TgmobqJbsD9h26Yu6eTXKqhivO1Jz797zf0fNBpS19AhnTTg@mail.gmail.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: 
 <CA+TgmobqJbsD9h26Yu6eTXKqhivO1Jz797zf0fNBpS19AhnTTg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/ab3128a9-2689-49b5-bf8a-99c74f4f0473%40oss.nttdata.com>
Precedence: bulk



On 2024/07/19 1:27, Robert Haas wrote:
> On Thu, Jul 18, 2024 at 9:47 AM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>> "WAL not generated under wal_level=minimal" sounds a bit confusing??
>> How about "WAL generated while wal_level is replica or higher" instead?
> 
> Committed and back-patched to 17 with approximately that change, but
> reworded slightly to make the tenses work.

Many thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION