Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sXAQi-0026Lb-UH for pgsql-hackers@arkaria.postgresql.org; Fri, 26 Jul 2024 02:11:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sXAQh-003rQy-G4 for pgsql-hackers@arkaria.postgresql.org; Fri, 26 Jul 2024 02:11:35 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sXAQh-003rQT-4I for pgsql-hackers@lists.postgresql.org; Fri, 26 Jul 2024 02:11:35 +0000 Received: from mout-u-107.mailbox.org ([2001:67c:2050:101:465::107]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sXAQe-001T7p-5H for pgsql-hackers@lists.postgresql.org; Fri, 26 Jul 2024 02:11:33 +0000 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4WVWTB0z9wz9t1K; Fri, 26 Jul 2024 04:11:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ewie.name; s=MBO0001; t=1721959886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hHYF7add0uWyPa8/+T5ktSmGaFghJGSNkyoruJaVYPo=; b=a9gCs1oGBeX+j0MSZ0A3YDx8Zo5reiHmeGAC0oM50R3O2URKCdo4q5v4OJaREtRbCsxnU4 hPlJ0d9NhcDIKLuW8pp5h9q2GGUPvs2bSnutNimD/YbDggRbJamcII/mkt/D2re63Vj/tJ pcuV7SgDd5DwnNRD57q/2oxtSPSyZ9sALdXHeW6V+uSoRxZIPYjzcdNebudQt1vyGf6fZF 2J0Nd972Pn6VmB6HH2R4GN8nQ+YpXlAl95Tm+wdPX8oTtZ7dxWMlRinRgu9CibksAKKIl2 pHFTXctE8STcpX21A2z0OBC5xXXsbXkhM2lWl9x22/hgL2TSWqUbumhaCEogUQ== Date: Fri, 26 Jul 2024 04:11:22 +0200 From: Erik Wienhold To: Tom Lane Cc: "David G. Johnston" , Robert Haas , Hannu Krosing , Peter Eisentraut , PostgreSQL Hackers Subject: Re: CREATE TABLE creates a composite type corresponding to the table row, which is and is not there Message-ID: References: <73jtqglviqor5ozqrthjmau7nj4xi7z4obzaqflf7cvliaf4em@4obr7wqlqkye> <1cd8a224-4038-43ba-bb11-a4cd8d015462@ewie.name> <1556597.1721939351@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1556597.1721939351@sss.pgh.pa.us> X-Rspamd-Queue-Id: 4WVWTB0z9wz9t1K List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2024-07-25 22:29 +0200, Tom Lane wrote: > Erik Wienhold writes: > > Thanks, I didn't know that guideline. Both fixed in v6. > > This still isn't following our usual message style IMO. Here's a > proposed v7 that outputs > > -ERROR: type stuff is not a composite type > +ERROR: type stuff is the row type of another table > +DETAIL: A typed table must use a stand-alone composite type created with CREATE TYPE. > > I did a bit of copy-editing on the docs changes too. One notable > point is that I dropped the parenthetical bit about "(name optionally > schema-qualified)". That struck me as quite unnecessary, and > it definitely doesn't read well to have two parenthetical comments > in a single four-line sentence. Works for me. Thanks! -- Erik