Content-Type: multipart/mixed; boundary="------------4bbkUbd0RiD1OrYcn0oTRyCh"
Message-ID: <ab4288f8-be5c-57fb-2400-e3e857f53e46@enterprisedb.com>
Date: Tue, 25 Jan 2022 09:32:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.0
Content-Language: en-US
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: libpq async duplicate error results
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>
Archived-At: 
 <https://www.postgresql.org/message-id/ab4288f8-be5c-57fb-2400-e3e857f53e46%40enterprisedb.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------4bbkUbd0RiD1OrYcn0oTRyCh
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


This issue was discovered by Fabien in the SHOW_ALL_RESULTS thread.  I'm 
posting it here separately, because I think it ought to be addressed in 
libpq rather than with a workaround in psql, as proposed over there.

When using PQsendQuery() + PQgetResult() and the server crashes during 
the execution of the command, PQgetResult() then returns two result sets 
with partially duplicated error messages, like this from the attached 
test program:

command = SELECT 'before';
result 1 status = PGRES_TUPLES_OK
error message = ""

command = SELECT pg_terminate_backend(pg_backend_pid());
result 1 status = PGRES_FATAL_ERROR
error message = "FATAL:  terminating connection due to administrator command
"
result 2 status = PGRES_FATAL_ERROR
error message = "FATAL:  terminating connection due to administrator command
server closed the connection unexpectedly
	This probably means the server terminated abnormally
	before or while processing the request.
"

command = SELECT 'after';
PQsendQuery() error: no connection to the server


This is hidden in normal use because PQexec() throws away all but the 
last result set, but the extra one is still generated internally.

Apparently, this has changed between PG13 and PG14.  In PG13 and 
earlier, the output is

command = SELECT 'before';
result 1 status = PGRES_TUPLES_OK
error message = ""

command = SELECT pg_terminate_backend(pg_backend_pid());
result 1 status = PGRES_FATAL_ERROR
error message = "FATAL:  terminating connection due to administrator command
"
result 2 status = PGRES_FATAL_ERROR
error message = "server closed the connection unexpectedly
	This probably means the server terminated abnormally
	before or while processing the request.
"

command = SELECT 'after';
PQsendQuery() error: no connection to the server

In PG13, PQexec() concatenates all the error messages from multiple 
results, so a user of PQexec() sees the same output before and after. 
But for users of the lower-level APIs, things have become a bit more 
confusing.

Also, why are there multiple results being generated in the first place?


[0]: 
https://www.postgresql.org/message-id/alpine.DEB.2.22.394.2112230703530.2668598@pseudo
--------------4bbkUbd0RiD1OrYcn0oTRyCh
Content-Type: text/plain; charset=UTF-8; name="test.c"
Content-Disposition: attachment; filename="test.c"
Content-Transfer-Encoding: base64

I2luY2x1ZGUgPHN0ZGlvLmg+CiNpbmNsdWRlIDxsaWJwcS1mZS5oPgoKc3RhdGljIHZvaWQK
cnVuX3F1ZXJ5KFBHY29ubiAqY29ubiwgY29uc3QgY2hhciAqY29tbWFuZCkKewoJaW50IHJj
OwoJUEdyZXN1bHQgKnJlczsKCWludCBjb3VudCA9IDA7CgoJZnByaW50ZihzdGRlcnIsICJj
b21tYW5kID0gJXNcbiIsIGNvbW1hbmQpOwoJcmMgPSBQUXNlbmRRdWVyeShjb25uLCBjb21t
YW5kKTsKCWlmIChyYyAhPSAxKQoJewoJCWNoYXIgKmVycm9yID0gUFFlcnJvck1lc3NhZ2Uo
Y29ubik7CgoJCWZwcmludGYoc3RkZXJyLCAiUFFzZW5kUXVlcnkoKSBlcnJvcjogJXMiLCBl
cnJvcik7CgkJcmV0dXJuOwoJfQoKCXdoaWxlICgocmVzID0gUFFnZXRSZXN1bHQoY29ubikp
KQoJewoJCUV4ZWNTdGF0dXNUeXBlIHN0YXR1czsKCgkJc3RhdHVzID0gUFFyZXN1bHRTdGF0
dXMocmVzKTsKCQlmcHJpbnRmKHN0ZGVyciwgInJlc3VsdCAlZCBzdGF0dXMgPSAlc1xuIiwg
Kytjb3VudCwgUFFyZXNTdGF0dXMoc3RhdHVzKSk7CgkJZnByaW50ZihzdGRlcnIsICJlcnJv
ciBtZXNzYWdlID0gXCIlc1wiXG4iLCBQUXJlc3VsdEVycm9yTWVzc2FnZShyZXMpKTsKCQlQ
UWNsZWFyKHJlcyk7Cgl9CgoJZnByaW50ZihzdGRlcnIsICJcbiIpOwoJcmV0dXJuOwp9Cgpp
bnQKbWFpbigpCnsKCVBHY29ubiAqY29ubjsKCgljb25uID0gUFFjb25uZWN0ZGIoIiIpOwoJ
aWYgKFBRc3RhdHVzKGNvbm4pICE9IENPTk5FQ1RJT05fT0spCgl7CgkJZnByaW50ZihzdGRl
cnIsICJDb25uZWN0aW9uIHRvIGRhdGFiYXNlIGZhaWxlZDogJXNcbiIsCgkJCVBRZXJyb3JN
ZXNzYWdlKGNvbm4pKTsKCQlyZXR1cm4gMTsKCX0KCglydW5fcXVlcnkoY29ubiwgIlNFTEVD
VCAnYmVmb3JlJzsiKTsKCXJ1bl9xdWVyeShjb25uLCAiU0VMRUNUIHBnX3Rlcm1pbmF0ZV9i
YWNrZW5kKHBnX2JhY2tlbmRfcGlkKCkpOyIpOwoJcnVuX3F1ZXJ5KGNvbm4sICJTRUxFQ1Qg
J2FmdGVyJzsiKTsKCglQUWZpbmlzaChjb25uKTsKCXJldHVybiAwOwp9Cg==

--------------4bbkUbd0RiD1OrYcn0oTRyCh--