Message-ID: <ab46bf8a5158d27cdbb6901f49a6e38dd23e619e.camel@j-davis.com>
Subject: Re: Allow pg_signal_backend members to use
 pg_log_backend_memory_stats().
From: Jeff Davis <pgsql@j-davis.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: bossartn@amazon.com, pgsql-hackers@postgresql.org
Date: Sun, 24 Oct 2021 20:31:37 -0700
In-Reply-To: <20211025.115333.563958443822411952.horikyota.ntt@gmail.com>
References: <e5cf6684d17c8d1ef4904ae248605ccd6da03e72.camel@j-davis.com>
	 <33F34F0C-BB16-48DE-B125-95D340A54AE8@amazon.com>
	 <d87b3a4fa3dacb103a8f3f50751ec9e638b2e2b1.camel@j-davis.com>
	 <20211025.115333.563958443822411952.horikyota.ntt@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/ab46bf8a5158d27cdbb6901f49a6e38dd23e619e.camel%40j-davis.com>
Precedence: bulk

On Mon, 2021-10-25 at 11:53 +0900, Kyotaro Horiguchi wrote:
> In other words, I don't think pg_signal_backends is not meant to
> control "log something on another session" or "rotate log file". 
> It's
> danger that if we allow somewone to rotate log files, that means to
> allow same user to terminate another session.

The current patch doesn't allow members of pg_signal_backend to rotate
the log file.

Do you think pg_signal_backend is the wrong group to allow usage of
pg_log_backend_memory_contexts()? Alternatively, it could simply not
GRANT anything, and leave that up to the administrator to choose who
can use it.

Regards,
	Jeff Davis