Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1seaQf-0096VI-Bp for pgsql-hackers@arkaria.postgresql.org; Thu, 15 Aug 2024 13:22:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1seaQd-00GgWN-RX for pgsql-hackers@arkaria.postgresql.org; Thu, 15 Aug 2024 13:22:11 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1seaQc-00GgWB-7L for pgsql-hackers@lists.postgresql.org; Thu, 15 Aug 2024 13:22:11 +0000 Received: from fout3-smtp.messagingengine.com ([103.168.172.146]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1seaQY-004zZ1-NS; Thu, 15 Aug 2024 13:22:09 +0000 Received: from phl-compute-03.internal (phl-compute-03.nyi.internal [10.202.2.43]) by mailfout.nyi.internal (Postfix) with ESMTP id 07D94138FD00; Thu, 15 Aug 2024 09:22:04 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Thu, 15 Aug 2024 09:22:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm2; t=1723728124; x=1723814524; bh=YIDV2ZYFmbsPNpIqfAIhuzDp8mreDYWN +u1VTRPYBH8=; b=Yr7SIB5KiVTjE6t4cQ323ssVNYOnlaoi1QaSutQbhHu0GaGc Dxdl/C8z++Xbrew+w8qVBC8iOslg6luNxfbR9FKdMQf4AeGQnBKhqXTrYKCYk5yW 2NuVnPzrbGdCSvm+GvuC7ShFb87aiVK4swRJlK7zlubw5HF5RUh694GsKsXscm3E tYDFqjqgXBfjXE6vVuNSHK57H3/ZREZRVca6V4JDjn1g1bEPirMPHyFhJi7f3mYU AuP/Q89daXoXW8t4AQ71r5pwzZA0xHcP8fHLK1I2Ph239NiKdKYgRezt9b8Wgh1C ytyD6+j7Yyc2Xir37zlwV+/2SmuWMKYNA8kKSA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1723728124; x= 1723814524; bh=YIDV2ZYFmbsPNpIqfAIhuzDp8mreDYWN+u1VTRPYBH8=; b=c +FH2wem0t8DUeMye1D4gJP/mwYCOg97LzDa2qJ4qE3Rl432i6afM7t5dqJeydqDt uUtxEslbhCdB7Okf4OatyKiC9RB+ci2MvE/v0M1fOJQoLgD1kIqvMjNQuGRG4NMx NDNLz9VXDtwl5SG3ObMsh8+U86KaGkhEXirQfFBJUVI4jxd35hLUFF0xdYaU19+S SH9uPvDy16HqOv+yLbFIWusD2zm0OjzNB+RDd9IaUvnOaA8WiaU721+xl1ndLnlW QScroRJaQeK7QNBwavI9YW6liNSDZoyGDwPWjat7TfmLj5VCa87KL1/Q/7aD2dQM 48g9uAoR0AoWabx4nntMQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddruddtiedgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdej necuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvghtvghrsegvihhsvg hnthhrrghuthdrohhrgheqnecuggftrfgrthhtvghrnhepgfejtdfhkeeftdeugfeileeh teeljeeghfeuledthfeutedvffdukeefjefhgeehnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhesvghishgvnhhtrhgruhhtrdho rhhgpdhnsggprhgtphhtthhopeeipdhmohguvgepshhmthhpohhuthdprhgtphhtthhope hmsggrnhgtkhesghhmgidrnhgvthdprhgtphhtthhopehpghhsqhhlsehjqdgurghvihhs rdgtohhmpdhrtghpthhtohephhhlihhnnhgrkhgrsehikhhirdhfihdprhgtphhtthhope hpghhsqhhlqdhhrggtkhgvrhhssehpohhsthhgrhgvshhqlhdrohhrghdprhgtphhtthho pehhohhlghgvrhesjhgrkhhosghsrdgtohhmpdhrtghpthhtohepjhgurghvihhssehpoh hsthhgrhgvshhqlhdrohhrgh X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 15 Aug 2024 09:22:02 -0400 (EDT) Message-ID: Date: Thu, 15 Aug 2024 15:22:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Improve error message for ICU libraries if pkg-config is absent To: Michael Banck , Jeff Davis Cc: Heikki Linnakangas , PostgreSQL Hackers , Holger Jakobs , Jeff Davis References: <66b5d05c.050a0220.7c8ce.a951@mx.google.com> <66b5e4e4.170a0220.3cbf42.a1a2@mx.google.com> <66bdac3d.170a0220.21e804.17df@mx.google.com> Content-Language: en-US From: Peter Eisentraut In-Reply-To: <66bdac3d.170a0220.21e804.17df@mx.google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 15.08.24 09:20, Michael Banck wrote: > On Wed, Aug 14, 2024 at 06:05:19PM -0700, Jeff Davis wrote: >> That looks good to me. Does anyone have a different opinion? If not, >> I'll go ahead and commit (but not backport) this change. > > What is the rationale not to backpatch this? The error message changes, > but we do not translate configure output, so is this a problem/project > policy to never change configure output in the back-branches? > > If the change is too invasive, would something like the initial patch I > suggested (i.e., in the absense of pkg-config, add a more targetted > error message) be acceptable for the back-branches? But it's not just changing an error message, it's changing the logic that leads to the error message. Have we really thought through all the combinations here? I don't know. So committing for master and then seeing if there is any further feedback seems most prudent. (I'm not endorsing either patch version here, just commenting on the process.)