Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 21 Mar 2026 14:55:33 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Jeff Davis <pgsql@j-davis.com>,
	Greg Sabino Mullane <htamfids@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Adding locks statistics
Message-ID: <ab4y1UQUsSS7bSVd@paquier.xyz>
References: <v76tz252usppu2turrn6wxiyyxmybzxhqck5b3amtsbzrc6yto@n26qnwvpkxqw>
 <aZgBTyzxWmPJL0Tt@ip-10-97-1-34.eu-west-3.compute.internal>
 <isi5wszczhusgjetxwe6khxa5mbm5jms3msmbhwl73jktxw7ic@3mympoumua76>
 <aZiZTX1l5pX+BOXn@ip-10-97-1-34.eu-west-3.compute.internal>
 <aaEoN1XexvGiFvYp@ip-10-97-1-34.eu-west-3.compute.internal>
 <abortN3ngqMcaBJ7@ip-10-97-1-34.eu-west-3.compute.internal>
 <abpfH33mR4Mp9dtO@paquier.xyz>
 <abq71eL7qIdWAxMD@ip-10-97-1-34.eu-west-3.compute.internal>
 <abufUya2oK-_PJ3E@paquier.xyz>
 <abvrRZo52Yx9ZzWQ@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Lo09U1TgnSNj3tsP"
Content-Disposition: inline
In-Reply-To: <abvrRZo52Yx9ZzWQ@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: 
 <https://www.postgresql.org/message-id/ab4y1UQUsSS7bSVd%40paquier.xyz>
Precedence: bulk


--Lo09U1TgnSNj3tsP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 19, 2026 at 12:25:41PM +0000, Bertrand Drouvot wrote:
> That's a good idea! I only moved LockTagType, LOCKTAG_LAST_TYPE, LockTagTypeNames
> and LOCKTAG into a new locktag.h. I chose not to move the SET_LOCKTAG_* macros
> because then we'd also need to move DEFAULT_LOCKMETHOD and USER_LOCKMETHOD that
> I think are better suited in lock.h.

While looking at the full set of declarations, I've come to disagree
to that: by moving the macros, we also do not need to know about the
internal field names of LOCKTAG across multiple headers.

> I did not check if there are any other files that could benefit of using
> locktag.h instead of lock.h but that's something I'll do and open a dedicated
> if any (once locktag.h is in the tree).

I have checked after that, and did not spot an area (except your patch
of course).  And applied this part.

> Not sure as we already have multixact-stats.

Ah, right.  I did not notice this one.  This existing name sounds OK
by me, then.
--
Michael

--Lo09U1TgnSNj3tsP
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmm+MtUACgkQnvQgOdby
QH2CqA/7BBtxyjYl5fO+oK/DPrqizLkNFgiTQU48TUQVDZnqEz/CWLf1ObM1L9Tf
3c/m3f64xXVU4K6n9hgBa0fRdw0mObmVV8dxld8DYsK4GdaxWQ6HFYwFUfl9+GBd
evxLpk/RkOwTyxnujJwSaHOCWqpAB+q50SylKMUtmgMzzdnpEAdltV3ksMmthb8r
K5Rw6ZjXanZkb3nhNoIiP6XnRmNT4rKFIMqhvPZJX0u9RBclEgzuRWJ5iPT9f5vz
dmXZAPEQHZxpgvrnrvmteZlgjeTOEQjDdqHeXKMT+kUzWQ6GNR1dp9/ZWQeOy44P
NWziDKFiSL4eZYqsG+foe+VGA9vyHYgtBi41MWJbuXNJrqvjXm7HB6J1NUJp3hZR
vZ0yOLeLmtNb+cUWMBj91PKdLhbKxbyNl4EoSEpdORnNldJEckTbDMl54iGWIhLg
I6iBe0uetVLbqbAODRaOfeCFWwSnwWlUPvYl4PZ4CSv6qOjr8shWeqm9EBfM+0nO
vOuE6V7n6ShqwoNpsmHiQH+BOJm3vYTQ4h8HgnP8npmKvTMYsmk+RWC1NxH7X/cu
xFZQiXs8CxWi7JdC3S8bmj23xRRdn5uDgppedXIeTwUjaXE5NlYr3RvkKJluwd8R
XKLK/emadBIaJmJOpb10tKp7AQjqGNlNKEvlwuhAGtw1WyyDSrY=
=QPDi
-----END PGP SIGNATURE-----

--Lo09U1TgnSNj3tsP--