public inbox for [email protected]  

help / color / mirror / Atom feed

From: Laurenz Albe <[email protected]>
To: David G. Johnston <[email protected]>
Cc: Erik Wienhold <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Fix output of zero privileges in psql
Date: Tue, 17 Oct 2023 15:05:56 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAKFQuwbWt6pvSFERENDh-v8bsahgSd1NDfxsRfFT4g_MNDu+ZQ@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<4tgcecleqgkynyat7t3innrsdpopeiukumb7s4f2gdw3zuzidb@27urnfsqebdy>
	<[email protected]>
	<hltc5k6wgxkrrsd5wuzt45elxr6wiyvgqkixmfqfkoxirpplsu@zt4uhz5yhdy4>
	<[email protected]>
	<lir6jx6hjhsqkskekrhtoflbjbedv7wqowvz5wc2a742by5i55@uqeiwszaksvs>
	<[email protected]>
	<5uytof65cguide4mjhxzakd5w74hpuppjsrqfwuywtcf2r2xwl@lbi4fc374nig>
	<[email protected]>
	<cww6udzxvxorpznocvufq42mly3qyi3wcjx45nhlbj3wm6rjfc@36pzmsfodow5>
	<[email protected]>
	<CAKFQuwbWt6pvSFERENDh-v8bsahgSd1NDfxsRfFT4g_MNDu+ZQ@mail.gmail.com>

On Mon, 2023-10-16 at 19:05 -0700, David G. Johnston wrote:
> Reading both threads I'm not seeing any specific rejection of the
> solution that we simply represent empty privileges as "(none)".
> 
> I see an apparent consensus that if we do continue to represent it
> as NULL that the printout should respect \pset null.
> 
> Tom commented in favor of (none) on the other thread with some
> commentary regarding how extremely rare it is; then turns around
> and is "fairly concerned" about changing the current blank presentation
> of its value which is going to happen for some people regardless
> of which approach is chosen.
> 
> Stuart, the original user complainant, seems to favor (none)
> 
> Erik seems to favors (none)
> 
> I favor (none)
> 
> It's unclear to me whether you Laurenz are against (none) or just
> trying to go with the group consensus that doesn't actually seem to
> be against (none).
> 
> I'm in favor of iterating on v1 on this thread (haven't read it yet)
> and presenting it as the proposed solution.  If that ends up getting
> shot down we can revive v5 (still need to review as well).

Thanks for that summary.  I prefer my version (simply display NULLs
as NULLs), but I am not wedded to it.  I had the impression that Tom
would prefer that too, but is woried if the incompatibility introduced
would outweigh the small benefit (of either patch).

So it is clear that we don't have a consensus.

I don't think I want to go ahead with my version of the patch unless
there is more support for it.  I can review Erik's original code, if
that design meets with more favor.

> We should probably post on that thread that this one exists and post a link to it.

Perhaps a good idea, yes.

Yours,
Laurenz Albe

view thread (23+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Fix output of zero privileges in psql
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox