Subject: Re: Poll: are people okay with function/operator table redesign?
From: "Jonathan S. Katz" <jkatz@postgresql.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
 Bruce Momjian <bruce@momjian.us>, Alvaro Herrera <alvherre@2ndquadrant.com>,
 Robert Haas <robertmhaas@gmail.com>, Steven Pousty <steve.pousty@gmail.com>,
 Pavel Stehule <pavel.stehule@gmail.com>,
 Isaac Morland <isaac.morland@gmail.com>,
 Pierre Giraud <pierre.giraud@dalibo.com>,
 PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
References: <20200423174343.GA16996@alvherre.pgsql>
 <19233.1587665407@sss.pgh.pa.us> <5561.1587922854@sss.pgh.pa.us>
 <13e5e408-bc59-e8ca-44f3-28a981b4fc7d@postgresql.org>
 <a47ea348-b9a0-02b7-5bcb-7a32143dd16f@postgresql.org>
 <11211.1587951842@sss.pgh.pa.us>
 <58de9544-be5b-f325-b5cc-cce4e2dda7d9@postgresql.org>
 <5651.1587991781@sss.pgh.pa.us>
 <b998a672-2525-1cba-ac64-b292f495919e@postgresql.org>
 <30469.1588087170@sss.pgh.pa.us> <8682.1588202983@sss.pgh.pa.us>
 <4894cde4-148d-f0cc-d6d8-182a46f13e1b@postgresql.org>
 <06f6b32d-a4cc-3723-5bc1-00fa674df961@postgresql.org>
 <11106.1588205727@sss.pgh.pa.us>
 <1c5ca197-f7f2-0300-46ce-4652c7f81d48@postgresql.org>
Autocrypt: addr=jkatz@postgresql.org; keydata=
 mQINBFtShwABEAC7PNHDUOTYuifpUCk23KqfxdQQkn4nkoxOXRK0+rAj36FiwqGB4TJFuOVZ
 sDFAEiSlC8Jt4y5Cs7B5tetT8JNd2cs6zp/udMJJDz9d65O9PDpdlMgAmIiTzpLlSdx8FG56
 DTksaDv1d8j3cTJPSE4/fWSxqzA7o3Y9UuL7atZPrzfImgpRKs0of7elIHwOa8GucjyhYqcR
 h60wFBJc2KXqQdDYRTZy43DSnY/0VNc0omiH355fustvpm+m5HjD3w7qZyfN3fpKJpnX1LCF
 f3MnPHaDGITIYGRCBXvf0UqUtD6OEVWPv2C2gyqWMIpWmZTOgDufltKyIByKBoS9x0PlFkij
 04X3KODCngt+N8Ssc9OICc6QSxhjoP48PYPdmiTmkrGuf0LX084wj1xeo1NX7XxZK39F6dTJ
 DhsIiW0sNS0xMxQHLHG9VLbPjx3SANQBh6BuryPz5ZupW9/TIDmkvprtU/oXfKgtfYm3fxmk
 EctxbWrEPsFTFPyuMqQu6l+xyQv0s1VLZfjNWaua6H1/gGoIt6kRnn5qMXDVVpijuWkHbv7G
 ngaQMd258UrrOEHnnjzhQ7jxMWV9D+emxbAtlIxnYvCWlV4IwAQhEHfvudqYaIY3hNWrvQ6H
 GB2KXoTZYN9g5djm14/5nj1IU5zOcovkjJnKhoo9iStnpFF2cwARAQABtCdKb25hdGhhbiBT
 LiBLYXR6IDxqa2F0ekBwb3N0Z3Jlc3FsLm9yZz6JAlQEEwEIAD4CGwMFCQeGH4AFCwkIBwIG
 FQoJCAsCBBYCAwECHgECF4AWIQT6hLaVryv3miBkP/HxBJxynxxlJwUCW1KJJQAKCRDxBJxy
 nxxlJwjrD/kBgqsW4QpNpTFw7ifRokZV08CCX4huPBJQ91rrv+UEWlEcotFBHVkYyHnpzARl
 tcZxhJ9CbFxjniH9cOTty5T/O1yolbOHtZSW8Z8aWV6BVEbjMb+BFxSSLm7RnvJdzQbGCZq2
 ZZvfVpB6z3EHYph4KDdVKvMFjoLskxmdS1DE0tE3zTxvoQsi24Q+HOS07kUjs6fsu/WICMfz
 mgO++AWG9Y0CvN0mm4TkujESzyKM9E5irD+leEMIcddl51Aa2c/VMfBXQbRmpHIgUFTmuHQD
 CnQih+9i3OJAksDg66SP8a7yiXv5mwvyDi1EfTGVKYR2j+pwyjwnC3oIbvDMmB3uTn2JIjnT
 iZKPVtAcAylXjubFltihQgNyuShdP4W+kBwZizhUFqUVL8Anx+KoytYmJPfMRFLGuK4obXKq
 a2ZS3k9KB+H+isOx2nFJOsc7V360Zp1DVaNmuiK10TT6QndShSPaqkJqFtCb6r92rZ9sZM/L
 3vtCI4Rrl3Pt1MgtENXupS8gZpJnAYS0j5A1PAZ09r6ANoaeMHspF+5J5fOHeEvqphXr36mm
 a83Vl1t4orPb0+QmmijmlpseDU63M88Aw5p3c4qj7t8Qr2EZ5zrn7/sFn5wOfbs8Nymxafif
 QCnlV2vg9p0m7vSk/yLJ4PFZvs52FgqAGRCdRn0s2EC99bkCDQRbUocAARAAv8ho/toQ9DG3
 j4f9h9n1aRHr2FlviN2Utpy6L8+dfDggO0geilmkGQOolZ2E60gGfye/kUtF9W3NByO4hxDR
 9u6qbOXcdqnuA+cc68EfqlWFJrVtYFxt0h4ElWYOYnIezKthriWch/FY70FGrxs3z8UHOHq5
 0wBW433eTvZm90WixBiXEt2v1DgW4Vr3ymfO7Aap/IYyPuE4JzgudAuAl0HKPyNEHWHG1dAb
 jX1RiCw9gknIDWQOF0B4UAaJctWGVcnZ3A2ULwNGMa1P9ZJlBWf1vcj01aiHMU0yQ7JjJiSp
 vfm9eM0uSLwRdDrJjyl5ZZqVumjdv2SMNQ8GvYRbEMys3GGDSt9zXgfCSUnPnJfYxjzBHRI6
 x44Wfsx8S6hWxepOogCJJ/g67Bk9mY8YV4klWIXDJVOL5jnBC09DbsZG81JaE2QxB8Y7W36Z
 Mroi9XMxg3s805hQAQUvdG/poU8hN8BWdrnTm/+4eQQp7gDY1ePDmGM6bJC+OHOSnFtR/f+7
 0zpKJ10cc7cBygGnl1yR3KjhFyAWUFvP4ZGziKCcpMwXZfe9PGuyA/YOubMphxIn3YsK2wrd
 faKZYX2GMZCZhMMcvx9IpQrxIJgU+VlwXu/O+Lk10VIPcxPJJwmpdI6HzcS8ZgG6IMcC444X
 XTuLaP8j2mgcMvYak3ScCykAEQEAAYkCPAQYAQgAJhYhBPqEtpWvK/eaIGQ/8fEEnHKfHGUn
 BQJbUocAAhsMBQkHhh+AAAoJEPEEnHKfHGUnReMP/RA2UhGQj+G4uBshkRLjpRysabdPqgQB
 dEBk6wYbio88Wg/2/hgY7UzmDDEwX3sZfQDcrI6+vIobI8uqstZID+WgAAa1JLfChMyVQnSy
 0zfWMOABXscc5tGuvFRZvJklTissMFjXUwaREEKp4ZikTvJ/62MCjSdtrUhnPLvoTsHTKRKD
 ichE+b5A54alwsubTijw12O6N22r5IjZiiSZV0u7dsShyKw+7wCSax9fuBoE43NMYf+dnjMK
 nerAQYUcZWYMnk+EC8RaqYAxv6XZ2tKx1AkGGktwkQIBwrz9IlDSvJ3LWJ2UIIuLRTdngNgg
 GIL4zzuUa2F56FqskQIuYMaNETk6LYfalBDQ6TVLAcgCPQxp4k4i/PRsZ3lZ2ZhRHRYciOvm
 kp+I6EfHwllQpYrWs1thluBGqlJSVJgKl0IOFvKLsQ6KKfqzAwh6FxrO5qajp4viNIgtWoFw
 O5Bp0jgFTbH2OrMWIRfUdUCH1Djbuo65svhNj7FNsQVYzHDI+Nd1I/LOBoPc3UorRMF2M4JV
 kUR7skOHWUbPTSNUr7qc14NSMY3PKjGeVGAsBVHBPvmRx/Ss2tW/TpJWpxg4pmquFQSXuaYh
 Yf4FN8Sxy320pcr+FqN8AhZkYJcNY82OTtR5VEKRC/mYcyq61qXIKqngydn79bJjGxHipxyF FmEC
Message-ID: <ab7803b4-f985-cf3d-267f-38b7311ca917@postgresql.org>
Date: Wed, 29 Apr 2020 22:04:39 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0)
 Gecko/20100101 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <1c5ca197-f7f2-0300-46ce-4652c7f81d48@postgresql.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="Q0c0otS7xUv4scroafa5AJNEz07lB53ha"
Precedence: bulk

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--Q0c0otS7xUv4scroafa5AJNEz07lB53ha
Content-Type: multipart/mixed; boundary="8mrqBlb3X5GNxSh8XlQGlpDniaTPmp7Z4"

--8mrqBlb3X5GNxSh8XlQGlpDniaTPmp7Z4
Content-Type: multipart/mixed;
 boundary="------------FBAC7216449BCDE785D926E3"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------FBAC7216449BCDE785D926E3
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

On 4/29/20 9:22 PM, Jonathan S. Katz wrote:
> On 4/29/20 8:15 PM, Tom Lane wrote:
>> "Jonathan S. Katz" <jkatz@postgresql.org> writes:
>>> On 4/29/20 7:40 PM, Jonathan S. Katz wrote:
>>>> I'll compromise on the temporary importants, but first I want to see=

>>>> what's causing the need for it. Do you have a suggestion on a page t=
o test?
>>
>> I haven't yet pushed anything dependent on the new markup, but
>> attached is a draft revision for the JSON section; if you look at
>> the SRFs such as json_array_elements you'll see the issue.

^ This was super helpful. Built locally, and made it really easy to
test. Thanks!

>>> From real quick I got it to here. With the latest copy of the doc bui=
lds
>>> it appears to still work as expected, but I need a section with the n=
ew
>>> "pre" block to test.
>>
>> Yeah, I see you found the same <p> and <pre> settings I did.
>>
>>> I think the "background-color: inherit !important" is a bit odd, and
>>> would like to trace that one down a bit more, but I did not see anyth=
ing
>>> obvious on my glance through it.
>>
>> I think it's coming from this bit at about main.css:660:
>>
>> pre,
>> code,
>> #docContent kbd,
>> #docContent tt.LITERAL,
>> #docContent tt.REPLACEABLE {
>>   font-size: 0.9rem !important;
>>   color: inherit !important;
>>   background-color: #f8f9fa !important;
>>   border-radius: .25rem;
>>   margin: .6rem 0;
>>   font-weight: 300;
>> }
>>
>> I had to override most of that.
>=20
> Yeah, I had started toying with that and saw no differences, but I woul=
d
> need to test against anything in particular. I'm pretty confident we ca=
n
> remove those importants, based on my desultory testing.
>=20
> I'll try and get the patch built + docs loaded, and see if we can safel=
y
> remove those.

Please see latest attached. I've eliminated the !important, condensed
the CSS, and the desultory (yes, my word of the week) testing did not
find issues in devel or earlier versions.

Please let me know if this works for you. If it does, I'll push it up to
pgweb.

Jonathan

--------------FBAC7216449BCDE785D926E3
Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0";
 name="website-style-v4.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
 filename="website-style-v4.patch"

diff --git a/media/css/main.css b/media/css/main.css
index 08ca255..07963f2 100644
--- a/media/css/main.css
+++ b/media/css/main.css
@@ -625,7 +625,7 @@ ul.actions {
 }
=20
 #docContent p {
-  margin-bottom: 1rem !important;
+  margin-bottom: 1rem;
 }
=20
 #docContent hr {
@@ -648,7 +648,7 @@ ul.actions {
 }
=20
 #docContent pre {
-  padding: 0.8rem !important;
+  padding: 0.8rem;
 }
=20
 pre,
@@ -658,7 +658,7 @@ code,
 #docContent tt.REPLACEABLE {
   font-size: 0.9rem !important;
   color: inherit !important;
-  background-color: #f8f9fa !important;
+  background-color: #f8f9fa;
   border-radius: .25rem;
   margin: .6rem 0;
   font-weight: 300;
@@ -799,6 +799,24 @@ code,
 	text-align: left;
 }
=20
+#docContent table.table th.func_table_entry p,
+#docContent table.table td.func_table_entry p {
+  margin-top: 0.1em 0 0.1em 0;
+  padding-left: 4em;
+  text-align: left;
+}
+
+#docContent table.table p.func_signature {
+  text-indent: -3.5em;
+}
+
+#docContent table.table td.func_table_entry pre.programlisting {
+  background-color: inherit;
+  border: 0;
+  margin: 0.1em 0 0.1em 0;
+  padding: 0 0 0 4em;
+}
+
 /**
  * Titles, Navigation
  */
@@ -1059,7 +1077,7 @@ i.fas.fa-search {
 pre {
   padding: 0.8rem;
   border: 1px solid #ced4da;
-  margin: 1rem 0 !important;
+  margin: 1rem 0;
 }
=20
 pre.code {

--------------FBAC7216449BCDE785D926E3--

--8mrqBlb3X5GNxSh8XlQGlpDniaTPmp7Z4--

--Q0c0otS7xUv4scroafa5AJNEz07lB53ha
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE+oS2la8r95ogZD/x8QSccp8cZScFAl6qMjcACgkQ8QSccp8c
ZScgRxAAjJ0GJkJ8WQAnX/zwgriV1VGXTbS0kyyi1bLhtSJnpiquYfTTaPy6MUnk
R4U1U1fKBj2Y16j6sV+Wr4ztCHZ2oQtilSYIvLMWaFUgC0QCApw4pnfE/e4J00kl
+2bhy0RBLcd8hkro+dCWSL7SSJGY/tETcYRk1kRVoJ+h6QfP4Pi7IX0iLtW4wD7h
6ZTG6z9uj/39MHpgTFvDDSoETq6tgIW150J1aqz/s1UFb6imhuJFts8dGOaaYTfK
BdVFFNBtOe25K3OJhhL3z1KwQJDmhG4BKc/GJUaLauyOOyPoP5nYFOA6EY8s5EDD
bBxH6nZiazOuLm00zwpwVyqmu4XAgn+X+6vRjkmugI0mK/1resfqAGVJCFqHROvr
z9b7ZmxVP5VqcJdXCYiVE2cHM07NELHglGpK4g8+BV5weiG39vZA6T+dVd3SmIoH
8y+L+otPzN5uUSXSnbmk73Fao5tB7/vjDlfjnEtVwzqFp0l7jnKFn42o9m/9ldBn
GEQsI4Ikg3F5e8b6fSVcXRtCYh1FcS6FRr87nceDPvYQ8EsQuCmk17uvCy2r4CWw
DKhPaK9ijOmuz8ChDLJTGioTLIGcL+p1hvDHCVSBjyCCq4dT+qhIw9EkDyD6C7hX
S+oivuuNoF/35bXVAFTVTHIm5jtYa8nLBI136qnX/FqU29sBMTU=
=4pB5
-----END PGP SIGNATURE-----

--Q0c0otS7xUv4scroafa5AJNEz07lB53ha--