public inbox for [email protected]  

help / color / mirror / Atom feed

From: Joe Conway <[email protected]>
To: Jeff Davis <[email protected]>
To: Daniel Verite <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Andrew Gierth <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: [email protected]
Subject: Re: Order changes in PG16 since ICU introduction
Date: Tue, 6 Jun 2023 15:21:25 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

On 6/6/23 15:18, Jeff Davis wrote:
> On Tue, 2023-06-06 at 15:09 +0200, Daniel Verite wrote:
>> FWIW I don't quite see how 0001 improve things or what problem it's
>> trying to solve.
> 
> The word "locale" is generic, so we need to make LOCALE/--locale apply
> to whatever provider is being used. If "locale" only applies to libc,
> using ICU will always be confusing and never be on the same level as
> libc, let alone the preferred provider.


Agree 100%

> The locale "C" is a special case, documented as a non-locale. So, if
> LOCALE/--locale apply to ICU, then either ICU needs to handle locale
> "C" in the expected way (v8 patch series); or when we see locale "C" we
> need to somehow change the provider into something that can handle it
> (v6 patch series changes it to the "none" provider).

+1 to the latter approach

> Please let me know if you disagree with the goal or the reasoning here.
> If so, please explain where you think we should end up, because the
> status quo does not seem great to me.

also +1

>> 0001 creates exceptions throughout the code so that when an ICU
>> collation has a locale name "C" or "POSIX" then it does not behave
>> like an ICU collation, even though pg_collation.collprovider='i'
>> To me it's neither desirable nor necessary that a collation that
>> has collprovider='i' is diverted to non-ICU semantics.
> 
> It's not very principled, but it matches what libc does.

Makes sense to me

-- 
Joe Conway
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Order changes in PG16 since ICU introduction
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox