Date: Tue, 10 Mar 2026 11:37:15 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: Sami Imseih <samimseih@gmail.com>, pgsql-hackers@lists.postgresql.org
Subject: Re: Add starelid, attnum to pg_stats and leverage this in pg_dump
Message-ID: <abBIu0lYyFYAq5fx@nathan>
References: 
 <CADkLM=cz=bEvRRj0mSffMrVW56M=1O-KqavCZv19on-MQrkZwg@mail.gmail.com>
 <aateiqvWO53UjoNI@nathan>
 <aathGcXAIpiUSP_s@nathan>
 <CAA5RZ0vCuDDd6-H00aabjLri0yO_AMJQ4Lb4017pepqU5WNyFg@mail.gmail.com>
 <aa7sZcuRrlkeVJGX@nathan>
 <CADkLM=eUR5co+o3PU8M=Fo8rRynj4xf=PFtt2KisD96bdrPEOg@mail.gmail.com>
 <CAA5RZ0s674FM8vcEqr+DUVjWOpYSPS-rG8uANdJKEnSyo+tObA@mail.gmail.com>
 <CADkLM=cYLk7bi3QVMBGWsFEzNfpqyV1Es3tWCwfERS88MdULWQ@mail.gmail.com>
 <aa81xZp421DSkHiW@nathan>
 <CADkLM=dhYeJtP+8h8k4ULCu-P1pNHmFyDFBm8B0WU6A6i+NgPQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CADkLM=dhYeJtP+8h8k4ULCu-P1pNHmFyDFBm8B0WU6A6i+NgPQ@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/abBIu0lYyFYAq5fx%40nathan>
Precedence: bulk

On Mon, Mar 09, 2026 at 06:42:46PM -0400, Corey Huinker wrote:
> If you want 0003 split into two (one for pg_stats_ext and one for
> pg_stats_ext_exprs) I can do that, but they felt like a package deal to me.

Sorry to throw a curveball here, but I think the best way to structure this
patch set is as follows:

* 0001: Just the test changes (e.g., replacing * with column lists).  By
doing that first, the actual functionality changes in 0002 will be easier
to see.

* 0002: Adding columns to the all the views (this one will do a catalog
bump).  If we need to make a couple of test adjustments to verify the OIDs
or attribute IDs, that's fine, but those can be pretty minimal.

* 0003: Associated pg_dump changes.

-- 
nathan