Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 12 Mar 2026 06:34:51 +0900
From: Michael Paquier <michael@paquier.xyz>
To: zhanghu <kongbaik228@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Add documentation for PG_ABS_SRCDIR, PG_ABS_BUILDDIR, PG_LIBDIR,
 PG_DLSUFFIX
Message-ID: <abHf-9DCoJrsPqjX@paquier.xyz>
References: <abDAWzHaesHLDFke@paquier.xyz>
 <CAB5m2Qt_jQ2UJNainsp+jhzjRS6rCPd5ti1MBwDoJnXXG2v_Vg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="li5hqe81R2E83jBE"
Content-Disposition: inline
In-Reply-To: 
 <CAB5m2Qt_jQ2UJNainsp+jhzjRS6rCPd5ti1MBwDoJnXXG2v_Vg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/abHf-9DCoJrsPqjX%40paquier.xyz>
Precedence: bulk


--li5hqe81R2E83jBE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 11, 2026 at 11:10:44AM +0800, zhanghu wrote:
> The doc changes look good overall. I applied the patch locally and render=
ed
> the documentation to HTML, the new page also looks good.
>=20
> A few minor nitpicks:
>=20
> +       <para>
> +        Name of extension for dynamically-loadable modules (e.g.
> +        <literal>.so</literal> on Linux).
> +       </para>
>=20
> I think we need a "the" before "dynamically-loadable".

Don't think this one's necessary here, actually, as it refers to a
general concept around modules.

> +      These are useful when dealing with function and object loading
> +      that require specific paths to work, like paths defined in a
> +      <command>CREATE FUNCTION</command> or <command>LOAD</command>
> +      command, for example.
>=20
> The ending "for example" sounds redundant, since "like" already conveys t=
he
> meaning of "for example".

WFM.
--
Michael

--li5hqe81R2E83jBE
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmmx3/sACgkQnvQgOdby
QH2gew//buLSTx4Vs/bsS2Otojnty/9b9gQYpCB5VODGmz6/4Nzv+WJ1Tq1hgjMd
Wcboaha04vm6bvNUCwFsFHXDwZCxofHE9l4zpjQAt7UDa81Moy+RZ//xOjS0Bd3m
OTOljsuUOhhfHayVxOycmqIKzxzfYsSjEgDHX/AUVUP+79Ks3Flb5x6umjb2BJdI
uWEzcJjYfUgD62bP+VAvXApRYJrbAV7bPgdNoRyCh2NuRAinLZgWf9vd7V7AmVb5
Ivroysah5I0XAd83D1uz0lSyF2fRQ4fjrSIM6Psfeb4NWSGTM/6BzNRjkbTX5QwI
+sIegNLbWIooVe3kMnKsJuiD07Rwu4qGLfwz8Ifoa4w8IfTtT4c1EtjN6d/m0GyA
W7dHjxRLklhPI7ICJBj1FtthBDCN5oLd6y0FHSRF/3BhJsQixHFqhlHSW/q8vgw9
Pmj0tXIlnFS9qHTCT7SIAatidP4aUOp8qy1TyvxAVf41M9UKNCJyfAmDCeyzRyIc
wiqIo4B6hPr7asNooco1BvhFv13ERxHjdAczfqh9ADjKALvQRkhBLkUuzujDrCf0
0wy83+672QZD/+UcTnItqKfucIvgbpAZgpJj0F4674J+CfM2lWsytTO4wlA6znoY
fBHER5WqKV7ckoT2z3/ZRHX53K4JpKe1m1JRGRhuxc2dEQhHf68=
=/Qqm
-----END PGP SIGNATURE-----

--li5hqe81R2E83jBE--