Subject: Re: Non-decimal integer literals
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <b239564c-cad0-b23e-c57e-166d883cb97d@enterprisedb.com>
From: Vik Fearing <vik@postgresfriends.org>
Message-ID: <abb04ce4-a6b8-1c95-fa16-dc87e851e106@postgresfriends.org>
Date: Wed, 8 Sep 2021 14:44:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <b239564c-cad0-b23e-c57e-166d883cb97d@enterprisedb.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/abb04ce4-a6b8-1c95-fa16-dc87e851e106%40postgresfriends.org>
Precedence: bulk

On 8/16/21 11:51 AM, Peter Eisentraut wrote:
> Here is a patch to add support for hexadecimal, octal, and binary
> integer literals:
> 
>     0x42E
>     0o112
>     0b100101
> 
> per SQL:202x draft.

Is there any hope of adding the optional underscores?  I see a potential
problem there as SELECT 1_a; is currently parsed as SELECT 1 AS _a; when
it should be parsed as SELECT 1_ AS a; or perhaps even as an error since
0x1_a would be a valid number with no alias.

(The standard does not allow identifiers to begin with _ but we do...)
-- 
Vik Fearing