MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Mon, 12 Sep 2022 17:03:25 +0900
From: Shinya Kato <Shinya11.Kato@oss.nttdata.com>
To: bt22kawamotok <bt22kawamotok@oss.nttdata.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PATCH]Feature improvement for MERGE tab completion
In-Reply-To: <c5730fb146c8ded48d537724e1456bfb@oss.nttdata.com>
References: <9f1ad2a87a58cd5e7d64f3993130958d@oss.nttdata.com>
 <359a46c295eae938d84552c11818ab62@oss.nttdata.com>
 <c5730fb146c8ded48d537724e1456bfb@oss.nttdata.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <abe74f1c1d4e83df6e71cf854c7ea56b@oss.nttdata.com>
Archived-At: 
 <https://www.postgresql.org/message-id/abe74f1c1d4e83df6e71cf854c7ea56b%40oss.nttdata.com>
Precedence: bulk

On 2022-09-12 15:53, bt22kawamotok wrote:
>> 	else if (TailMatches("USING", MatchAny, "ON", MatchAny, "WHEN"))
>> 		COMPLETE_WITH("MATCHED", "NOT MATCHED");
>> 	else if (TailMatches("USING", MatchAny, "AS", MatchAny, "ON",
>> MatchAny, "WHEN"))
>> 		COMPLETE_WITH("MATCHED", "NOT MATCHED");
>> 	else if (TailMatches("USING", MatchAny, MatchAny, "ON", MatchAny, 
>> "WHEN"))
>> 		COMPLETE_WITH("MATCHED", "NOT MATCHED");
>> 
>> I thought it would be better to describe this section as follows,
>> summarizing the conditions
>> 
>> 	else if (TailMatches("USING", MatchAny, "ON", MatchAny, "WHEN") ||
>> 			 TailMatches("USING", MatchAny, "AS", MatchAny, "ON", MatchAny, 
>> "WHEN") ||
>> 			 TailMatches("USING", MatchAny, MatchAny, "ON", MatchAny, "WHEN"))
>> 		COMPLETE_WITH("MATCHED", "NOT MATCHED");
>> 
>> There are similar redundancies in the tab completion of MERGE
>> statement, so why not fix that as well?
> 
> Thanks for your review.
> 
> A new patch has been created to reflect the changes you indicated.

Thanks for updating!

Compile errors have occurred, so can you fix them?
And I think we can eliminate similar redundancies in MERGE tab 
completion and I would like you to fix them.

For example,

	else if (TailMatches("WHEN", "MATCHED"))
		COMPLETE_WITH("THEN", "AND");
	else if (TailMatches("WHEN", "NOT", "MATCHED"))
		COMPLETE_WITH("THEN", "AND");

above statement can be converted to the statement below.

	else if (TailMatches("WHEN", "MATCHED") ||
			 TailMatches("WHEN", "NOT", "MATCHED"))
		COMPLETE_WITH("THEN", "AND");


-- 
Regards,

--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION