Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 16 Mar 2026 16:23:40 +0900
From: Michael Paquier <michael@paquier.xyz>
To: "Aya Iwata (Fujitsu)" <iwata.aya@fujitsu.com>
Cc: Peter Smith <smithpb2250@gmail.com>,
	Pavel Stehule <pavel.stehule@gmail.com>,
	Chao Li <li.evan.chao@gmail.com>,
	"Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PROPOSAL] Termination of Background Workers for ALTER/DROP
 DATABASE
Message-ID: <abev_E-SE94zHP0n@paquier.xyz>
References: 
 <OS7PR01MB1196405302B700736580DEE49EAA8A@OS7PR01MB11964.jpnprd01.prod.outlook.com>
 <CAFj8pRBk7zTKoxAAKAihNQuimztniWHPyRWHKp2iHq_2hH+dvQ@mail.gmail.com>
 <OS7PR01MB11964C83E8E543743581250B0EAB3A@OS7PR01MB11964.jpnprd01.prod.outlook.com>
 <CAHut+PvP6H2soK05c_0JZC8--=h4nWEtxYE_nJGjRkQr=25F1w@mail.gmail.com>
 <aVs3IpiYjmq3gLEn@paquier.xyz>
 <CAHut+PtSVYKU4vfaRev4FMdbeZ3ukvxRy4X7uK05jv_9WMYafA@mail.gmail.com>
 <OS7PR01MB1196426354C0294148A06AC65EA86A@OS7PR01MB11964.jpnprd01.prod.outlook.com>
 <CAHut+PtZh+B_-z_TzmToUhL4-sBrf7dfH0uAb7VU-jkXFmHQSA@mail.gmail.com>
 <aVyfvgMplnc6aIE2@paquier.xyz>
 <OS3PR01MB8889505E2F3E443CCA4BD72EEA45A@OS3PR01MB8889.jpnprd01.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ukI4qtU61MWScRO8"
Content-Disposition: inline
In-Reply-To: 
 <OS3PR01MB8889505E2F3E443CCA4BD72EEA45A@OS3PR01MB8889.jpnprd01.prod.outlook.com>
Archived-At: 
 <https://www.postgresql.org/message-id/abev_E-SE94zHP0n%40paquier.xyz>
Precedence: bulk


--ukI4qtU61MWScRO8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 13, 2026 at 11:38:51AM +0000, Aya Iwata (Fujitsu) wrote:
> On March 10th, the bgworker test "t/002_worker_terminate.pl" failed on th=
e Build Farm.
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Djay&dt=3D2026-0=
3-10%2019%3A26%3A19

Indeed.

> We are currently attempting to reproduce this issue and are considering a=
 fix.
>=20
> According to the log, the test failed because the bgworker cannot be term=
inated
> within the time frame (5 seconds) when ALTER DATABASE RENAME is executed.
>=20
> So I suspect that there is a lock conflict.

Aye, we have a timing issue here, and at first it seemed to me that
this was a bug in the backend logic.  But actually I suspect that it
is simpler than that: we don't disable autovacuum so couldn't an
autovacuum worker connect to the database "testdb" that we are trying
to rename in this query?  I cannot be 100% sure because we have
reduced the log activity for the sake of the tests, but that feels
possible to me.  We could try to disable autovacuum entirely, then see
if the situation gets better in the buildfarm.

The failure rate is so low that it is likely going to take a few weeks
to check the stability of the situation.  We could also lot more
things, of course, as a temporary solution.

What do you think?
--
Michael

--ukI4qtU61MWScRO8
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmm3r/wACgkQnvQgOdby
QH1N6A//We1W5AIxd0XeRVfaEiWm10tKnaPW2cOOA9LHmpwuXSGemfU1cqKgbfYy
XSVF2iWMKtLsAg9rQMwilWAjE8DW47Tv/A9U3RVG8ZZRe4vD+SX2c6UUN0882wG6
Ud9jbwrdIQpjiadbuGliYTuXoaohS8+JPf6H5eXnftr+7ofdXr8YxTgJpKIuJXlW
KRqVMKMNNHHxB9oskjyoFnwN5trEl/JEPjRW1Y7yWPMA/BwqYlmC2DoyEEZKUuW5
HpBfbuHaK+F7dNFRteEVkIi+2jsEZcNdM/G7G2A9d9B2m36myu970WC/8PRWmldq
SQ1bdpEFfj30WnQW1PlP84iAEMz6jOhHHvsl5havFA9Fq/RZizgBExZvb678Y9KO
H/EJAsV6U7MmKdXJGTJmlsJ9KekkCSg7q7JgD98u3PZKQCoNqZQJnqzBTHZlRiUM
1pz3n1/tSC/v8B6a1SzPX/FLyWxx+/0LMJeJMP97Bt4PVNXrdwjuVGU4ovWH4nn4
/v5efIy8HmxWGFrF/3XqrRd3wDbUTNl7UGAaJOfCGFiORTwU7lU7KQ3HhMHCIb8J
uvb8LLbN+C4n3Dr/CEWtbMEx2+PHvAJL1djpCGi/x6S+/I+H1cdiIYlvcP2hEYaH
7etZqFhY5rIMzJURLlzToOKEdHjhjTxyo6mhCd7T/hH8H2Q/0HM=
=DlZE
-----END PGP SIGNATURE-----

--ukI4qtU61MWScRO8--