Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 16 Mar 2026 17:51:34 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: tablecmds: reject CLUSTER ON for partitioned tables earlier
Message-ID: <abfElj6aqmazkgb1@paquier.xyz>
References: 
 <CAEoWx2k5800OjHO5KhTDv4JFYpDmyfh3MTtuB=7PP-0hLmG8yQ@mail.gmail.com>
 <07773235-2E94-478F-BEF6-38C73B0553B8@gmail.com>
 <EA6CB317-60C2-4BA9-8E02-DBCAD384F107@gmail.com>
 <CAN4CZFMUJWM0veLK93Ew8mYaL5pcU6G550STh6AZ-_LWV2zS+w@mail.gmail.com>
 <16D5D52A-1B99-4371-982E-257C195D2924@gmail.com>
 <CAN4CZFPX_t9q4W=jTh4jW4TOz=Xhfv0gPi9jG0MfXv9Ek7BO5w@mail.gmail.com>
 <5244008D-79E1-484B-9407-21F5D388EC7F@gmail.com>
 <CAN4CZFMjyPYqNY6qD4ArRZKUyC4oEPAfu-OesfChGMwMq1CG_w@mail.gmail.com>
 <075DECA0-5214-4794-A265-5A979E1A49B7@gmail.com>
 <8A3FAABD-F297-41D1-9B07-20A37E311C29@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="9EPJDhwveaHqQA29"
Content-Disposition: inline
In-Reply-To: <8A3FAABD-F297-41D1-9B07-20A37E311C29@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/abfElj6aqmazkgb1%40paquier.xyz>
Precedence: bulk


--9EPJDhwveaHqQA29
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 13, 2026 at 11:38:17AM +0800, Chao Li wrote:
> On Jan 28, 2026, at 10:15, Chao Li <li.evan.chao@gmail.com> wrote:
>> * In 0001, replaced ereport with assert in
>> mark_index_clustered(). See my previous email for the analysis.=20

I have looked at this one, and I think that it is right.  Even in the
CLUSTER/VACUUM path, we have a relkind check before the sole caller of
rebuild_relation() that discards partitioned tables, so we would never
read mark_index_clustered() under this relkind.  Applied.

>> * In 0002, removed the redundant check of relispartition from
>> * ATExecDropInherit().

I have not looked at this one.
--
Michael

--9EPJDhwveaHqQA29
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmm3xJYACgkQnvQgOdby
QH24wBAAor/ZSHjiZg+QewQOrM5VfIWfwToZ4MnoS6ysGGxK+Bfc8wFS3KJ+S3Aw
I936veoHlstM9pg4JKOHi9AuyW91PWYZhAaCIi1u6gmsTehshQMTH5cuI4wggG6P
x0zXT2jR64GufznB0Z8XC9fqpDxY91OQOt+z4bc+B5c4BuFGGbg3CPsPSyzJJyCt
1MjE5pD5YSUS/5KAWWqbNegms5uae90b23keRs5I/ARG1Um/KGnwfVIn3Y4ZCvbX
cettZbFPyRlf1mva20dCdOqzGMkc6c7DDnBsTQMwcVdgQ8H4s7xNTlZkP1cRB1Vl
WUtzH46fRRug6q9FUzvI1Jqmj7l7wL3RUvQ4mnakgsp6j1STd9j0PHrjP/FqoqhM
jt1BLNN5TNhV7yWMIHAZKFA6TGUp4CxBjDCyS03raNmnJCNzIFsO2hgvlZqEKGXD
Cwj3ggSrFucEYwWkQDv3kb582XUbN0He6bV2g/3cqcbIjO/oh2CG4Mn+K0oyTcqV
ORL5vL9TRQtRyKuE3p0TDfTKCskGbC/ZpPkFdqy+K6MjN6H6Whrhh0GdwcbHlfks
nbJ6t6H7HNg9xvBKboalRGWPIAwhBoovmXCeDJsof7DZP2RW67gvbfWAsDful3VD
ks1NTHV1FlIcnVTm1VdYdThAq89TxjwvS5MifIRndev0N38RzZQ=
=XYIM
-----END PGP SIGNATURE-----

--9EPJDhwveaHqQA29--