Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w2N6z-000EN6-33 for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Mar 2026 05:37:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w2N6y-00G8sk-2T for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Mar 2026 05:37:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w2N6x-00G8sc-34 for pgsql-hackers@lists.postgresql.org; Tue, 17 Mar 2026 05:37:00 +0000 Received: from fhigh-b8-smtp.messagingengine.com ([202.12.124.159]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w2N6u-00000000YFK-3F0J for pgsql-hackers@lists.postgresql.org; Tue, 17 Mar 2026 05:36:59 +0000 Received: from phl-compute-11.internal (phl-compute-11.internal [10.202.2.51]) by mailfhigh.stl.internal (Postfix) with ESMTP id 5AFB27A01CA; Tue, 17 Mar 2026 01:36:54 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Tue, 17 Mar 2026 01:36:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1773725813; x=1773812213; bh=6y3iGE95eQ IxJ15vkbV9Au315iq6740tBdlN4yjgmlY=; b=VoJ9rYhk6uEtmJOPzp3zNiPJRt JsE6gEKLjjAFEQR31q9oqGRh8VeJ6Z6XWzesavb8YGxsPZLixpxr5zBITnmOaqfp 2MeYCraWHWXBNmyPGt1GkM41fQ5QlDIsagm73BCEQODC3zfqezQBlNIucXPcE2Uz spw4jQTR0dKopAvGkSim9GLoKhzOffsIRAjfrS4obri2QhiB0kQBy0SD4k7DTfzz hCmhWjzNgfnNlPbuK+vvQM5n3aaYk0YyMB4uo3fbhWS6cRUW27+kG/UQmV7zrggM uXS2b+6FTQHxrieWJYiMa1/nRUcRrdsbpTqArQUQSfIX6fQuSP7EhsLMivzw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1773725813; x=1773812213; bh=6y3iGE95eQIxJ15vkbV9Au315iq6740tBdl N4yjgmlY=; b=ozZjhlUqGBGKTFDsOjhSgsLLJdbEziKt+mXiZ+k0xaOr53K8b/W GqDlnGLIT6kGguE9lMR8qbwLWwjINqqQROe/Ckkf9t0yoD7zUkYmpLmX1SlytNai SQsNuhIcPSydsygLpaf+w8MA7YarjkHDgidDEDuapOI0A1CNj7ac/cY7o/3sWoIY /NmhHuQJ0l/26/KYIu51c3UvTebaJXCI2B1M2Febmi6lcuBpCbzcQYuC5UOMTeWd XNtyUZtxZR7m7yqgyaNgtqvV5HylcvBVr0g85porbFVqpq+8hp/8IEH2KlVNK76z TXWD7se7JEG3ZVbTm+aykRj32GZ2V4jzETw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdeftddtgeegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrh hlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeggeeg fffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiidp nhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheplhhird gvvhgrnhdrtghhrghosehgmhgrihhlrdgtohhmpdhrtghpthhtohepphhgshhqlhdqhhgr tghkvghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 Mar 2026 01:36:52 -0400 (EDT) Date: Tue, 17 Mar 2026 14:36:48 +0900 From: Michael Paquier To: Chao Li Cc: Postgres hackers Subject: Re: tablecmds: reject CLUSTER ON for partitioned tables earlier Message-ID: References: <16D5D52A-1B99-4371-982E-257C195D2924@gmail.com> <5244008D-79E1-484B-9407-21F5D388EC7F@gmail.com> <075DECA0-5214-4794-A265-5A979E1A49B7@gmail.com> <8A3FAABD-F297-41D1-9B07-20A37E311C29@gmail.com> <602D405C-63BC-4383-AD43-28841CAF91C1@gmail.com> <6407218E-1E7A-4B38-A038-562FF3D51548@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="miAZtQZFBiWSookO" Content-Disposition: inline In-Reply-To: <6407218E-1E7A-4B38-A038-562FF3D51548@gmail.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --miAZtQZFBiWSookO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 17, 2026 at 09:12:13AM +0800, Chao Li wrote: > Anyway, I added the asserts in ATExecAddInherit() and > ATExecDropInherit() in v9. If you have a second thought, I can tune > it further. I have removed the assertions at the end, after looking at the surroundings for hints. > PFA v9: > * 0001 - added a NO INHERIT test case in typed_table.sql > * 0002 - added asserts in ATExecAddInherit and ATExecDropInherit. The comments rmeoved from ATPrepAddInherit() were still not at the correct location. CreateInheritance() is the routine in charge of the column and constraint checks. -- Michael --miAZtQZFBiWSookO Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmm46HAACgkQnvQgOdby QH1Mqg/8DxA8+pAE9D1Qv2fQrSgfUGlY07Wc0yis29gSHD/Ffe2Yff/yBVdzk5qM 9k75Gr4mGjG2E/jPmIU9U0CXHD2yfx82xOw0kNG4V2ILb6oIgQzNj4/g3KDVrz2z 4a95IG0DuWGI+m4XuyFCH7edc/mW3ZIsRWD2si2acaZF4jlcJCcU4jaZiwRPDl4g 8dJufFSpnvGw+asDgxbcexvr5wiEz7xuXsaoKFuSGnyYeJctbIPxWKP+Hz6VoggV yjlbtreMvPwySwH/qpwkvDc70CKqEDqHvo2Zofiy6ZKY+T4YIhilk63121Pvb36Z zCAZ7XV5y/9H0e4843yBiqUuaRjxJKszl628ljeXhohNVP13q0A4GxHcKBw1fo2N dohFVD2ZBQ40Ybko3vGfR+LWJM7AFDFQlaHFgCqRIIQIWAJJy2ol46o6WYVEB5ec k3ZZOlTO7Hy0kkNgsxwaa5e2JVHaOLwlwvhEYtLaSRFAYpW9NNeoAxs33aZeUCQw Zc3lBqpoISUNAPEYwR/NxygIbkSvIO8tE0+BqUhYbA9EN5wzC21oqQ5U9lLcHdc3 inPNX7aE7wEBceUeMyUZnsP4xHtJyrUonDrJUH5SSdsrIg+d2daw8hHjPvy4UDeE Fp5Fle3rCsSWCuc15aNvAQCGmk1hmYYNlKKfXKDPV7/bGOT3Mv4= =ceMr -----END PGP SIGNATURE----- --miAZtQZFBiWSookO--