Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 17 Mar 2026 14:51:12 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Haibo Yan <tristan.yim@gmail.com>
Cc: David Steele <david@pgbackrest.org>,
	Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Return pg_control from pg_backup_stop().
Message-ID: <abjr0A2IfnBvuHJw@paquier.xyz>
References: <83f5295e-082d-432c-92a4-365707bd2296@pgbackrest.org>
 <Zv4hdzZURFAYYAL5@paquier.xyz>
 <1248c005-b693-494a-8d7a-68bc7d482679@pgbackrest.org>
 <fe9a5423-c36d-43ad-9884-dee4c3b7dc6d@pgbackrest.org>
 <edc09339-3a4c-4195-8c06-7aa2953ca5be@pgbackrest.org>
 <d388dba5-dc68-4dab-9b8d-ca301956e85b@pgbackrest.org>
 <8b8aa673-fcef-4e14-a05d-0885283ef1b8@pgbackrest.org>
 <d21f3c7c-563c-49db-8983-faa73ed4369f@pgbackrest.org>
 <f74cab02-5ebb-439c-975b-29d019eed787@pgbackrest.org>
 <17DC1346-0CDE-4E39-B110-3D6FB0797AC6@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="AEnoXSk1dVxl8shx"
Content-Disposition: inline
In-Reply-To: <17DC1346-0CDE-4E39-B110-3D6FB0797AC6@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/abjr0A2IfnBvuHJw%40paquier.xyz>
Precedence: bulk


--AEnoXSk1dVxl8shx
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 16, 2026 at 10:16:58PM -0700, Haibo Yan wrote:
> I have not read the code yet, so this may already be answered there,
> but I had a question about the proposal itself. This patch protects
> against a missing backup_label, but what about a wrong one? If a
> user restores a backup_label file from a different backup, the
> existence check alone would not detect that. Do we need some
> consistency check between the returned pg_control copy and the
> backup_label contents, or is the intended scope here limited to the
> =E2=80=9Cmissing file=E2=80=9D case only?=20

Please note that we use bottom-posting on the lists, as of:
https://en.wikipedia.org/wiki/Posting_style#Bottom-posting
--
Michael

--AEnoXSk1dVxl8shx
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmm469AACgkQnvQgOdby
QH2fcQ/9Ec2lRSZy2THshXFRzRbcLHR6GILE8Dqk9nJSsQa58wjmfrTMxKDrrJy+
MItXZLL9m0ntE1kNygrsKkYA8gwCs6SRNdqZI6BgepZPWcp8e209nx/NQ+RCQKEt
Imz8lvjI9q/+/hwAcWTbi3/V1noIYaH8CpZBh0MqXSsihqiwwJNDY9cMLtzgUHhZ
9LzpHLpwu/hbPLGQ5t3xiVeUi3MrIqgVa9r8wEdc4XFxwWiF3DmaMZhqBYrdNV1J
9sNjCepvqh+0iQI+M0tryAXlkJ8dz2/rniSOCj7UF6D2KNdM0y3NV2SLlUCiutOu
P2Vrkh+PN5CH/I+loNw+xJsSe0Bi3pCUKCIhCXuRsZehXh1ZQ0rdXw+cVhfNnqFX
i/Je/+3Kjy62v+Xbl0muaXV3I+N3ZO79zibHDSeFVwRlAXFeQk4RGtK1oV/DEUna
jxXSZBaRi56sdpqIiKJAvQR2S8j3ffdMULTKcKK5f1U0espUnEGrrPTnIubG63Sh
eRt3lM/KxkN0TqCdegXqB+0HQxelB2D+n5M0tQRYosBbxHALkxlt8J4jrvTRUchu
Q+advW0eKpxwvaiH2ed15hXzLmxWQcXGWO6ewwqhH9ZROc/id4eyKeiVhDIJ55mO
HsvBjonv2Nfqpr29N4gxf64QvyFAyXXOhrIwi9apZz3FTjoZyl4=
=+Im4
-----END PGP SIGNATURE-----

--AEnoXSk1dVxl8shx--