public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Zsolt Parragi <[email protected]>
Cc: Chao Li <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: gen_guc_tables improvements
Date: Tue, 17 Mar 2026 17:40:32 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAN4CZFNSTSLQ5=haC80i79LR+=bGMbzgfkEtFvPFXZS2JTgBBg@mail.gmail.com>
References: <CAN4CZFP=3xUoXb9jpn5OWwicg+rbyrca8-tVmgJsQAa4+OExkw@mail.gmail.com>
<[email protected]>
<CAN4CZFNSTSLQ5=haC80i79LR+=bGMbzgfkEtFvPFXZS2JTgBBg@mail.gmail.com>
On Mon, Mar 16, 2026 at 05:57:39AM +0000, Zsolt Parragi wrote:
> Yes, but by convention dot is only used by extensions to mark the
> prefix/namespace of the extension (<extension_name>.<guc_name>). None
> of the core server GUCs use it. The point of this script isn't to
> ensure that the generated C code will compile, but to prevent hidden
> errors and ensure we follow existing proper coding conventions.
I am not sure that it is a good idea to enforce that in the script
this way, to be honest. There may be a point about this new rule
being annoying for forks of the core code, at least, where they would
like to add their own parameters with dots in the names. I have done
that in the past, as one example, and I am sure that there are
projects out there that do so, meaning the requirement to live with
one more custom patch to make things work if this rule is enforced in
gen_guc_tables.pl.
Saying that, as far as I can see 0001 and 0003 will save some time
when inserting some incorrect data. The case of duplicated names was
indeed confusing, and 0003 can save from typos when specifying
non-mandatory fields. So I have applied these two.
0004 has some value here, to save the .dat from copy-paste bloat. I
am wondering what others think about it.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
view thread (4+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: gen_guc_tables improvements
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox