Date: Tue, 17 Mar 2026 11:45:41 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Mahendra Singh Thalor <mahi6run@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_restore --format= option(without any value) should report an
 error as pg_dump is reporting an error
Message-ID: <abmFNYjgs1oa3asB@nathan>
References: 
 <CAKYtNApkh=Vy2DpNRCnEJmPpxNuksbAh_QBav=2fLmVjBhGwFw@mail.gmail.com>
 <CAKYtNApxyeeQbjxjFCgHwuv0T2TJvFaU6QSQaMU_yr1nP4Y8Fg@mail.gmail.com>
 <1d66a1e5-ce44-448b-8407-31d5ed9bc10d@dunslane.net>
 <CAKYtNArQ-c8xfBaWOKBB6TPVM5Fd_d0v2UEpxk9f5BuKyrQYxQ@mail.gmail.com>
 <abhbSpewJZz0H999@nathan>
 <CAKYtNArN7Tyn7n0wp8BxcpkfBn3gi01QZJS55sbj=qmdyoNO4A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAKYtNArN7Tyn7n0wp8BxcpkfBn3gi01QZJS55sbj=qmdyoNO4A@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/abmFNYjgs1oa3asB%40nathan>
Precedence: bulk

On Tue, Mar 17, 2026 at 02:51:56PM +0530, Mahendra Singh Thalor wrote:
> I did some more testing and found that if there is an empty string with
> --port/--host, then we don't report any error because we don't validate
> empty strings. This looks weird to me but this is happening with all tools
> so I was not adding any test case for --host and --port.

Oh, weird.

Unless new feedback materializes, I'll proceed with committing your patch
within the next day or so.

-- 
nathan