Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 18 Mar 2026 17:26:43 +0900
From: Michael Paquier <michael@paquier.xyz>
To: David Steele <david@pgbackrest.org>
Cc: Haibo Yan <tristan.yim@gmail.com>,
	Pg Hackers <pgsql-hackers@postgresql.org>,
	Heikki Linnakangas <hlinnaka@iki.fi>,
	Robert Haas <robertmhaas@gmail.com>,
	Andres Freund <andres@anarazel.de>,
	Fujii Masao <masao.fujii@gmail.com>
Subject: Re: Return pg_control from pg_backup_stop().
Message-ID: <abphw4g2TwuPP0Cv@paquier.xyz>
References: <8b8aa673-fcef-4e14-a05d-0885283ef1b8@pgbackrest.org>
 <d21f3c7c-563c-49db-8983-faa73ed4369f@pgbackrest.org>
 <f74cab02-5ebb-439c-975b-29d019eed787@pgbackrest.org>
 <17DC1346-0CDE-4E39-B110-3D6FB0797AC6@gmail.com>
 <feb68313-3257-4d9d-8b69-6468e506a61a@pgbackrest.org>
 <7F7B289B-F94F-42C2-9E54-6A689C0D64BB@gmail.com>
 <aboDQSoywyKGGNCr@paquier.xyz>
 <1800c83c-264a-4183-9da5-ac78e25849a8@pgbackrest.org>
 <abov3-Kre8ntiL-S@paquier.xyz>
 <3b23e3b7-53d2-4784-b482-05cca3327acb@pgbackrest.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="2HioA4FJdLDOm6KQ"
Content-Disposition: inline
In-Reply-To: <3b23e3b7-53d2-4784-b482-05cca3327acb@pgbackrest.org>
Archived-At: 
 <https://www.postgresql.org/message-id/abphw4g2TwuPP0Cv%40paquier.xyz>
Precedence: bulk


--2HioA4FJdLDOm6KQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Mar 18, 2026 at 07:35:47AM +0000, David Steele wrote:
> You are correct -- the copy of pg_control needs to happen before
> do_pg_backup_stop(). An older version of this patch saved pg_control in
> backup_state which made the prior location safe. However, I missed moving
> this code when I moved pg_control out of backup_state. Code review to the
> rescue.

Right.  I am wondering also if the final result would not be better
without 0002, actually, focusing only on the "simpler" base backup
case through the replication protocol, and you are making a good case
in mentioning it as not absolutely mandatory for base backups that are
taken through the SQL functions.  One could always tweak the flag
manually in the control file based on the contents taken from the data
folder.  That's more hairy than writing the entire file, for sure,
still possible.
--
Michael

--2HioA4FJdLDOm6KQ
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmm6YcMACgkQnvQgOdby
QH2XPhAAp3Q7DOO8wYj/NcpCgqN6KDyui8ntb6DikKXEP/Oo5nVMn/YqtlpEhTox
Ec1C+hNf+oIA8akJ6W22nnqbdfK1fWVWXAi+cPqhX1hLqHDsnS4+bfOhkrtsiobW
FDxlgs8rlbmU9DrS3l4/HDkySrAxWRd1Gzyh0Bb+H45Vlt3zHfrRst4s5ATR5nVp
DsPBndzf9hOQYIdIkN42nxUljHW0bX5g7E06ugeipSs8tXx+JCzE73SHLEo3PKRj
Lc4PvwECcOMJKTTjTF2GbznncCkXL3NAxz7KrobtQtdPqTLHBO3uXnSEMHfj0RNV
5/mJew9oHaCHY3/p9v3xH25uyeh2uTuHp2wDyPNq7uVlIlSIC7qn7uXbl9PfXIHm
7857HOXSEfhwSxwn3jmHBwse36XClAuy6iFGbdfnHg+CSXVbzAB8veb1v5PD1u60
gKs5TD/KEYLaSUB72n+Lss5aMk9ceX+4yZB+Swo+g3cdkossVQXobGMyKvB0tv0p
5kbcntYiIiB7CmJJ+yBtwP/mLnCkuso7Ls4M7LgEAI4Xw8tmFJd+1h0ngdaocpo3
FVUQm794NPVBHUBrFNjM7J9+m8geY4b6CUpiCwgoVG55fAXB58iVO47WfGsRADuq
/K2qsZ30+TgMmz3dPrA9Y++pxSAzmQZNbd++e241xynD3t7My08=
=Gepy
-----END PGP SIGNATURE-----

--2HioA4FJdLDOm6KQ--