Date: Wed, 18 Mar 2026 19:15:33 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>,
	Peter Eisentraut <peter@eisentraut.org>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Enable -Wstrict-prototypes and -Wold-style-definition by default
Message-ID: <abr51elajA2zUOl7@ip-10-97-1-34.eu-west-3.compute.internal>
References: <aa73q1aT0A3/vke/@ip-10-97-1-34.eu-west-3.compute.internal>
 <44885d54-0376-46b3-b574-59e0e3098580@eisentraut.org>
 <dfb1373e-258f-42b7-ac76-0f5858936dfa@eisentraut.org>
 <CAN55FZ1VDwJ-ZD092ChYf++huP+-S3Cg45tJ8jNH5wx2c4BHAg@mail.gmail.com>
 <784253.1773853383@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="kE1qhMB7tHROlKew"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <784253.1773853383@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/abr51elajA2zUOl7%40ip-10-97-1-34.eu-west-3.compute.internal>
Precedence: bulk


--kE1qhMB7tHROlKew
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

Hi,

On Wed, Mar 18, 2026 at 01:03:03PM -0400, Tom Lane wrote:
> Nazir Bilal Yavuz <byavuz81@gmail.com> writes:
> > I got this warning while running headerscheck after this commit:

Thanks for the report!

> > ~/Desktop/projects/postgres/src/interfaces/ecpg/ecpglib/ecpglib_extern.h:221:40:
> > warning: function declaration isn’t a prototype [-Wstrict-prototypes]
> >   221 | void            ecpg_init_sqlca(struct sqlca_t *sqlca)
> 
> Yeah, I see that too.  I believe the problem is that headerscheck
> doesn't cause POSTGRES_ECPG_INTERNAL to become defined, so that
> what the compiler is seeing is (from sqlca.h):
> 
> 	#ifndef POSTGRES_ECPG_INTERNAL
> 	#define sqlca (*ECPGget_sqlca())
> 	#endif
> 
> and then
> 
> 	void		ecpg_init_sqlca(struct sqlca_t *sqlca);

Oh right, confirmed with:

"
$ gcc -E -I src/interfaces/ecpg/include -I src/include -I src/interfaces/libpq \ 
    -include src/include/postgres_fe.h src/interfaces/ecpg/ecpglib/ecpglib_extern.h \
     | grep ECPGget_sqlca

$ struct sqlca_t *ECPGget_sqlca(void);
$ void ecpg_init_sqlca(struct sqlca_t *(*ECPGget_sqlca()));
"
> Kinda surprising that that's not a syntax error.

Yeah...

> We could plausibly fix this either by
> 
> (1) renaming ecpg_init_sqlca's parameter to something else;
> 
> (2) ensuring that POSTGRES_ECPG_INTERNAL is defined.  I'd be inclined
> to make ecpglib_extern.h do that rather than expecting headerscheck
> to know about it.
> 
> Neither of these options are beautiful, but perhaps #1 is slightly
> less ugly.  Any preferences?

I'd vote for #1 too, done in the attached.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

--kE1qhMB7tHROlKew
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="v1-0001-Fix-Wstrict-prototypes-warning-in-ecpg_init_sqlca.patch"